Skip to content

Commit 09e2a99

Browse files
Add pylint fixes to tree determinism code
1 parent d6504db commit 09e2a99

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

Orange/widgets/visualize/owtreeviewer2d.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
QBrush, QPen, QColor, QPainter, QPainterPath, QTransform
55
)
66
from AnyQt.QtWidgets import (
7-
QGraphicsItem, QGraphicsEllipseItem, QGraphicsRectItem, QGraphicsTextItem,
7+
QGraphicsItem, QGraphicsEllipseItem, QGraphicsTextItem,
88
QGraphicsLineItem, QGraphicsScene, QGraphicsView, QStyle, QSizePolicy,
99
QFormLayout
1010
)
@@ -287,7 +287,7 @@ def brect(node):
287287

288288
if node.branches and node.isOpen:
289289
for n in node.branches:
290-
x, ry = self._fix_pos(n, x, y + self._VSPACING + brect(node).height())
290+
x, _ = self._fix_pos(n, x, y + self._VSPACING + brect(node).height())
291291
x = (node.branches[0].pos().x() + node.branches[-1].pos().x()) / 2
292292
node.setPos(x, y)
293293
for e in node.graph_edges():
@@ -435,7 +435,7 @@ def send_report(self):
435435

436436
if self.model:
437437
self.reportSection("Tree")
438-
urlfn, filefn = self.getUniqueImageName(ext=".svg")
438+
_, filefn = self.getUniqueImageName(ext=".svg")
439439
svg = QSvgGenerator()
440440
svg.setFileName(filefn)
441441
ssize = self.scene.sceneRect().size()

Orange/widgets/visualize/tests/test_owpythagorastree.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,7 @@ def _check_all_same(data):
301301

302302
# Make sure the tree are deterministic for iris
303303
scene_nodes = []
304-
for i in range(n_tries):
304+
for _ in range(n_tries):
305305
self.send_signal(self.signal_name, self.signal_data)
306306
scene_nodes.append([n.pos() for n in self.get_visible_squares()])
307307
for node_row in zip(*scene_nodes):
@@ -317,7 +317,7 @@ def _check_all_same(data):
317317
path.dirname(__file__), "../../tests/datasets/same_entropy.tab"))
318318
data_same_entropy = TreeLearner()(data_same_entropy)
319319
scene_nodes = []
320-
for i in range(n_tries):
320+
for _ in range(n_tries):
321321
self.send_signal(self.signal_name, data_same_entropy)
322322
scene_nodes.append([n.pos() for n in self.get_visible_squares()])
323323
for node_row in zip(*scene_nodes):

Orange/widgets/visualize/tests/test_owtreegraph.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ def _check_all_same(data):
6060

6161
# Make sure the tree are deterministic for iris
6262
scene_nodes = []
63-
for i in range(n_tries):
63+
for _ in range(n_tries):
6464
self.send_signal(self.signal_name, self.signal_data)
6565
scene_nodes.append([n.pos() for n in self.widget.scene.nodes()])
6666
for node_row in zip(*scene_nodes):
@@ -73,7 +73,7 @@ def _check_all_same(data):
7373
# Make sure trees are deterministic with data where some variables have
7474
# the same entropy
7575
scene_nodes = []
76-
for i in range(n_tries):
76+
for _ in range(n_tries):
7777
self.send_signal(self.signal_name, self.data_same_entropy)
7878
scene_nodes.append([n.pos() for n in self.widget.scene.nodes()])
7979
for node_row in zip(*scene_nodes):

0 commit comments

Comments
 (0)