Skip to content

Commit 0aa74d7

Browse files
authored
Merge pull request #2571 from PrimozGodec/scatterfix
Fixed scatterplot labels when not all data displayed due to missing values
2 parents ca9292e + 93d3747 commit 0aa74d7

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

Orange/widgets/visualize/owscatterplotgraph.py

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -691,17 +691,17 @@ def update_data(self, attr_x, attr_y, reset_view=True):
691691
x_data, y_data, rgb_data)
692692
self.plot_widget.addItem(self.density_img)
693693

694-
data_indices = np.flatnonzero(self.valid_data)
695-
if len(data_indices) != self.original_data.shape[1]:
694+
self.data_indices = np.flatnonzero(self.valid_data)
695+
if len(self.data_indices) != self.original_data.shape[1]:
696696
self.master.Information.missing_coords(
697697
self.shown_x.name, self.shown_y.name)
698698

699699
self.scatterplot_item = ScatterPlotItem(
700-
x=x_data, y=y_data, data=data_indices,
700+
x=x_data, y=y_data, data=self.data_indices,
701701
symbol=shape_data, size=size_data, pen=color_data, brush=brush_data
702702
)
703703
self.scatterplot_item_sel = ScatterPlotItem(
704-
x=x_data, y=y_data, data=data_indices,
704+
x=x_data, y=y_data, data=self.data_indices,
705705
symbol=shape_data, size=size_data + SELECTION_WIDTH,
706706
pen=color_data_sel, brush=brush_data_sel
707707
)
@@ -943,8 +943,11 @@ def create_labels(self):
943943

944944
def _create_label_column(self):
945945
if self.attr_label in self.data.domain:
946-
return self.data.get_column_view(self.attr_label)[0]
947-
return self.master.data.get_column_view(self.attr_label)[0]
946+
label_column = self.data.get_column_view(self.attr_label)[0]
947+
else:
948+
label_column = self.master.data.get_column_view(self.attr_label)[0]
949+
return label_column[self.data_indices]
950+
948951

949952
def update_labels(self):
950953
if self.attr_label is None or \

0 commit comments

Comments
 (0)