Skip to content

Commit 0de0d42

Browse files
committed
[FIX] Update checker: LooseVersion doesn't handle str parts
E.g., '3.4.1' vs '3.4.dev' crashes on 'dev' with TypeError and unorderable types.
1 parent 9ba1d91 commit 0de0d42

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Orange/canvas/__main__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,7 +124,6 @@ def check_for_updates():
124124
settings.setValue('startup/last-update-check-time', int(time.time()))
125125

126126
from urllib.request import urlopen
127-
from distutils.version import LooseVersion
128127
from Orange.version import version as current
129128

130129
class GetLatestVersion(QThread):
@@ -138,7 +137,8 @@ def run(self):
138137
log.exception('Failed to check for updates')
139138

140139
def compare_versions(latest):
141-
if LooseVersion(latest) <= LooseVersion(current):
140+
version = pkg_resources.parse_version
141+
if version(latest) <= version(current):
142142
return
143143
question = QMessageBox(
144144
QMessageBox.Information,

0 commit comments

Comments
 (0)