owfile: Parse and encode url

Author: ales-erjavec

Orange/widgets/data/owfile.py

@@ -470,6 +470,10 @@ def _get_reader(self) -> FileFormat:
             return reader
         else:
             url = self.url_combo.currentText().strip()
+            # tolerant parse, also prevent parsing as local file
+            parsed = QUrl.fromUserInput(url, os.devnull)
+            if parsed.isValid():
+                url = bytes(parsed.toEncoded()).decode("ascii")
             return UrlReader(url)
 
     def _update_sheet_combo(self):

Orange/widgets/data/tests/test_owfile.py

@@ -577,6 +577,21 @@ def test_url_no_scheme(self):
 
         mock_urlreader.assert_called_once_with('http://' + url)
 
+    def test_url_encode(self):
+        def test(text, expected):
+            mock_urlreader = Mock()
+            with patch('Orange.widgets.data.owfile.UrlReader', mock_urlreader):
+                self.widget.url_combo.insertItem(0, text)
+                self.widget.url_combo.setCurrentIndex(0)
+                self.widget.url_combo.activated.emit(0)
+            mock_urlreader.assert_called_once_with(expected)
+
+        test("https://example.com/space space#f=f", "https://example.com/space%20space#f=f")
+        test("https://example.com/space%20space#f=f", "https://example.com/space%20space#f=f")
+        test("https://š.si/š#f=1", "https://xn--pga.si/%C5%A1#f=1")
+        test("https://xn--pga.si/%C5%A1#f=1", "https://xn--pga.si/%C5%A1#f=1")
+        test("https://example.com/a?q=1#f=1", "https://example.com/a?q=1#f=1")
+
     def test_adds_origin(self):
         self.open_dataset("origin1/images")
         data1 = self.get_output(self.widget.Outputs.data)