Skip to content

Commit 137367a

Browse files
committed
PCA - Making lint happier
1 parent 509e41d commit 137367a

File tree

2 files changed

+8
-7
lines changed

2 files changed

+8
-7
lines changed

Orange/widgets/unsupervised/owpca.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
from AnyQt.QtCore import Qt
66

77
from orangewidget.report import bool_str
8+
from orangewidget.settings import Setting
89

910
from Orange.data import Table, Domain, StringVariable, ContinuousVariable
1011
from Orange.data.util import get_unique_names

Orange/widgets/unsupervised/tests/test_owpca.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@
44
from unittest.mock import patch, Mock
55

66
import numpy as np
7+
from sklearn.utils import check_random_state
8+
from sklearn.utils.extmath import svd_flip
79

810
from Orange.data import Table, Domain, ContinuousVariable, TimeVariable
911
from Orange.preprocess import preprocess
1012
from Orange.widgets.tests.base import WidgetTest
1113
from Orange.widgets.tests.utils import table_dense_sparse, possible_duplicate_table
1214
from Orange.widgets.unsupervised.owpca import OWPCA
1315
from Orange.tests import test_filename
14-
from sklearn.utils import check_random_state
15-
from sklearn.utils.extmath import svd_flip
1616

1717

1818
class TestOWPCA(WidgetTest):
@@ -63,19 +63,19 @@ def test_limit_components(self):
6363
self.widget._setup_plot() # pylint: disable=protected-access
6464

6565
def test_migrate_settings_limits_components(self):
66-
settings = dict(ncomponents=10)
66+
settings = {"ncomponents": 10}
6767
OWPCA.migrate_settings(settings, 0)
6868
self.assertEqual(settings['ncomponents'], 10)
69-
settings = dict(ncomponents=101)
69+
settings = {"ncomponents": 101}
7070
OWPCA.migrate_settings(settings, 0)
7171
self.assertEqual(settings['ncomponents'], 100)
7272

7373
def test_migrate_settings_changes_variance_covered_to_int(self):
74-
settings = dict(variance_covered=17.5)
74+
settings = {"variance_covered": 17.5}
7575
OWPCA.migrate_settings(settings, 0)
7676
self.assertEqual(settings["variance_covered"], 17)
7777

78-
settings = dict(variance_covered=float('nan'))
78+
settings = {"variance_covered": float('nan')}
7979
OWPCA.migrate_settings(settings, 0)
8080
self.assertEqual(settings["variance_covered"], 100)
8181

@@ -282,7 +282,7 @@ def test_table_subclass(self):
282282
When input table is instance of Table's subclass (e.g. Corpus) resulting
283283
tables should also be an instance subclasses
284284
"""
285-
class TableSub(Table):
285+
class TableSub(Table): # pylint: disable=abstract-method
286286
pass
287287

288288
table_subclass = TableSub(self.iris)

0 commit comments

Comments
 (0)