Merge pull request #1876 from ales-erjavec/fixes/silhouette-plot-type-error

[FIX] owsilhouetteplot: Fix TypeError when cluster column is an object array

Author: astaric

Orange/widgets/visualize/owsilhouetteplot.py

@@ -260,6 +260,7 @@ def _update(self):
 
         labelvar = self.cluster_var_model[self.cluster_var_idx]
         labels, _ = self.data.get_column_view(labelvar)
+        labels = numpy.asarray(labels, dtype=float)
         mask = numpy.isnan(labels)
         labels = labels.astype(int)
         labels = labels[~mask]

Orange/widgets/visualize/tests/test_owsilhouetteplot.py

@@ -4,6 +4,7 @@
 
 import numpy as np
 
+import Orange.data
 from Orange.widgets.utils.annotated_data import ANNOTATED_DATA_SIGNAL_NAME
 from Orange.widgets.visualize.owsilhouetteplot import OWSilhouettePlot
 from Orange.widgets.tests.base import WidgetTest, WidgetOutputsTestMixin
@@ -72,3 +73,14 @@ def test_unknowns_in_labels(self):
         self.assertTrue(np.all(np.isfinite(scores_1)))
         # the scores must match
         np.testing.assert_almost_equal(scores_1, scores[valid], decimal=12)
+
+    def test_meta_object_dtype(self):
+        # gh-1875: Test on mixed string/discrete metas
+        data = self.data[::5]
+        domain = Orange.data.Domain(
+            data.domain.attributes, [],
+            [data.domain["iris"],
+             Orange.data.StringVariable("S")]
+        )
+        data = data.from_table(domain, data)
+        self.send_signal("Data", data)