Limit scikit-learn requirement to <0.23

Author: PrimozGodec

Orange/base.py

@@ -523,11 +523,7 @@ def _get_sklparams(self, values):
             spec = list(
                 inspect.signature(skllearner.__init__).parameters.keys()
             )
-            # first argument is 'self'
-            assert spec[0] == "self"
-            params = {
-                name: values[name] for name in spec[1:] if name in values
-            }
+            params = {name: values[name] for name in spec if name in values}
         else:
             raise TypeError("Wrapper does not define '__wraps__'")
         return params

Orange/projection/base.py

@@ -199,11 +199,7 @@ def _get_sklparams(self, values):
             spec = list(
                 inspect.signature(sklprojection.__init__).parameters.keys()
             )
-            # first argument is 'self'
-            assert spec[0] == "self"
-            params = {
-                name: values[name] for name in spec[1:] if name in values
-            }
+            params = {name: values[name] for name in spec if name in values}
         else:
             raise TypeError("Wrapper does not define '__wraps__'")
         return params

requirements-core.txt

@@ -1,7 +1,7 @@
 pip>=9.0
 numpy>=1.16.0
 scipy>=0.16.1
-scikit-learn>=0.22.0
+scikit-learn>=0.22.0,<0.23  # TODO: release when fixed: https://github.com/scikit-learn/scikit-learn/issues/17208
 bottleneck>=1.0.0
 # Reading Excel files
 xlrd>=0.9.2