Skip to content

Commit 194572b

Browse files
authored
Merge pull request #6723 from ajdapretnar/stack-error
Stack: new table instead of transform
2 parents c17d656 + 3bb991d commit 194572b

File tree

2 files changed

+15
-2
lines changed

2 files changed

+15
-2
lines changed

Orange/ensembles/stack.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ def fit_storage(self, data):
8181
dom = Domain([ContinuousVariable('f{}'.format(i + 1))
8282
for i in range(X.shape[1])],
8383
data.domain.class_var)
84-
stacked_data = data.transform(dom).copy()
84+
stacked_data = Table.from_table(dom, data)
8585
with stacked_data.unlocked_reference():
8686
stacked_data.X = X
8787
stacked_data.Y = res.actual

Orange/tests/test_stack.py

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import unittest
22

33
from Orange.data import Table
4-
from Orange.ensembles.stack import StackedFitter
4+
from Orange.ensembles.stack import StackedFitter, StackedLearner
55
from Orange.evaluation import CA, CrossValidation, MSE
66
from Orange.modelling import KNNLearner, TreeLearner
77

@@ -26,3 +26,16 @@ def test_regression(self):
2626
mse = MSE()(results)
2727
self.assertLess(mse[0], mse[1])
2828
self.assertLess(mse[0], mse[2])
29+
30+
def test_timeseries(self):
31+
def aggregate(data):
32+
assert type(data) is Table
33+
34+
class CustomTable(Table):
35+
pass
36+
37+
sl = StackedLearner([TreeLearner(), KNNLearner()],
38+
aggregate=aggregate)
39+
40+
data = CustomTable(self.iris)
41+
sl(data)

0 commit comments

Comments
 (0)