Skip to content

Commit 1970245

Browse files
authored
Merge pull request #4232 from lanzagar/owfile-keepdata
[FIX] File: Fix domain edit on no changes
2 parents 074a238 + 546dd32 commit 1970245

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

Orange/widgets/data/owfile.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -484,6 +484,8 @@ def apply_domain_edit(self):
484484
domain, cols = self.domain_editor.get_domain(self.data.domain, self.data)
485485
if not (domain.variables or domain.metas):
486486
table = None
487+
elif domain is self.data.domain:
488+
table = self.data
487489
else:
488490
X, y, m = cols
489491
table = Table.from_numpy(domain, X, y, m, self.data.W)

Orange/widgets/data/tests/test_owfile.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -321,6 +321,13 @@ def test_no_specified_reader(self):
321321
self.widget.load_data()
322322
self.assertTrue(self.widget.Error.missing_reader.is_shown())
323323

324+
def test_domain_edit_no_changes(self):
325+
self.open_dataset("iris")
326+
data = self.get_output(self.widget.Outputs.data)
327+
# When no changes have been made in the domain editor,
328+
# output data should be the same object (and not recreated)
329+
self.assertTrue(data is self.widget.data)
330+
324331
def test_domain_edit_on_sparse_data(self):
325332
iris = Table("iris").to_sparse()
326333

0 commit comments

Comments
 (0)