Skip to content

Commit 19bd4a2

Browse files
committed
concurrent: Remove task.deleteLater calls
Allow PyOwned to fully handle the disposal
1 parent c5f8daf commit 19bd4a2

File tree

1 file changed

+1
-6
lines changed

1 file changed

+1
-6
lines changed

Orange/widgets/utils/concurrent.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -527,10 +527,6 @@ def __cancel_task(self, wait: bool = True):
527527
self._disconnect_signals(state)
528528
if wait:
529529
concurrent.futures.wait([state.future])
530-
state.deleteLater()
531-
else:
532-
w = FutureWatcher(state.future, parent=state)
533-
w.done.connect(state.deleteLater)
534530

535531
def _connect_signals(self, state: TaskState):
536532
state.partial_result_ready.connect(self.on_partial_result)
@@ -545,8 +541,7 @@ def _on_task_done(self, future: Future):
545541
assert self.__task is not None
546542
assert self.__task.future is future
547543
assert self.__task.watcher.future() is future
548-
self.__task, task = None, self.__task
549-
task.deleteLater()
544+
self.__task = None
550545
ex = future.exception()
551546
if ex is not None:
552547
self.on_exception(ex)

0 commit comments

Comments
 (0)