Skip to content

Commit 24c7ab2

Browse files
authored
Merge pull request #4583 from ales-erjavec/tests-cleanup
Tests cleanup
2 parents e925d51 + d460309 commit 24c7ab2

File tree

3 files changed

+8
-1
lines changed

3 files changed

+8
-1
lines changed

Orange/widgets/data/tests/test_owoutliers.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,15 @@ def test_no_data(self):
3838

3939
class TestOWOutliers(WidgetTest):
4040
def setUp(self):
41+
super().setUp()
4142
self.widget = self.create_widget(OWOutliers)
4243
self.iris = Table("iris")
4344
self.heart_disease = Table("heart_disease")
4445

46+
def tearDown(self):
47+
self.widget.onDeleteWidget()
48+
super().tearDown()
49+
4550
def test_outputs(self):
4651
"""Check widget's data and the output with data on the input"""
4752
self.send_signal(self.widget.Inputs.data, self.iris)

Orange/widgets/evaluate/owtestlearners.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1089,6 +1089,7 @@ def cancel(self):
10891089

10901090
def onDeleteWidget(self):
10911091
self.cancel()
1092+
self.__executor.shutdown(True)
10921093
super().onDeleteWidget()
10931094

10941095

Orange/widgets/unsupervised/tests/test_owtsne.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ def tearDown(self):
5555
# Some tests may not wait for the widget to finish, and the patched
5656
# methods might be unpatched before the widget finishes, resulting in
5757
# a very confusing crash.
58-
self.widget.cancel()
58+
self.widget.onDeleteWidget()
5959
try:
6060
self.restore_mocked_functions()
6161
# If `restore_mocked_functions` was called in the test itself, stopping
@@ -150,6 +150,7 @@ def test_multiscale_changed_updates_ui(self):
150150
self.send_signal(w.Inputs.data, self.data, widget=w)
151151
self.assertTrue(w.controls.multiscale.isChecked())
152152
self.assertFalse(w.perplexity_spin.isEnabled())
153+
w.onDeleteWidget()
153154

154155
def test_normalize_data(self):
155156
# Normalization should be checked by default

0 commit comments

Comments
 (0)