Skip to content

Commit 27d5ef3

Browse files
lanzagarjanezd
authored andcommitted
owfeaturestatistics: Do not crash on empty domain
1 parent ad0004c commit 27d5ef3

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

Orange/widgets/data/owfeaturestatistics.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -827,7 +827,7 @@ def __restore_selection(self):
827827
def __restore_sorting(self):
828828
"""Restore the sort column and order from saved settings."""
829829
sort_column, sort_order = self.sorting
830-
if self.data is not None and sort_column < self.model.columnCount():
830+
if self.model.n_attributes and sort_column < self.model.columnCount():
831831
self.model.sort(sort_column, sort_order)
832832
self.table_view.horizontalHeader().setSortIndicator(sort_column, sort_order)
833833

Orange/widgets/data/tests/test_owfeaturestatistics.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -200,6 +200,10 @@ def test_does_not_crash_on_data_removal(self):
200200
self.send_signal(self.widget.Inputs.data, make_table(discrete))
201201
self.send_signal(self.widget.Inputs.data, None)
202202

203+
def test_does_not_crash_on_empty_domain(self):
204+
empty_data = Table('iris').transform(Domain([]))
205+
self.send_signal(self.widget.Inputs.data, empty_data)
206+
203207
# No missing values
204208
@table_dense_sparse
205209
def test_on_data_with_no_missing_values(self, prepare_table):

0 commit comments

Comments
 (0)