Skip to content

Commit 2aa859b

Browse files
authored
Merge pull request #2470 from ales-erjavec/fixes/table-del-ids
[FIX] table: Update `ids` in `Table.__del__`
2 parents aabdccd + 7bf27d0 commit 2aa859b

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

Orange/data/table.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -819,6 +819,7 @@ def __delitem__(self, key):
819819
self.Y = np.delete(self._Y, key, axis=0)
820820
self.metas = np.delete(self.metas, key, axis=0)
821821
self.W = np.delete(self.W, key, axis=0)
822+
self.ids = np.delete(self.ids, key, axis=0)
822823

823824
def __len__(self):
824825
return self.X.shape[0]

Orange/tests/test_table.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -356,6 +356,13 @@ def test_del_slice_example(self):
356356
del d[:]
357357
self.assertEqual(len(d), 0)
358358

359+
def test_del_slice_ids(self):
360+
# __del__ updates `ids` member
361+
d = data.Table("test2")
362+
ids = d.ids.copy()
363+
del d[2:4]
364+
np.testing.assert_array_equal(d.ids, np.delete(ids, slice(2, 4)))
365+
359366
def test_set_slice_example(self):
360367
import warnings
361368

0 commit comments

Comments
 (0)