[FIX] Silhouette Plot: now setting axis range properly

https://sentry.io/biolab/orange3/issues/220334718/

Author: jerneju

Orange/widgets/visualize/owsilhouetteplot.py

@@ -389,7 +389,7 @@ def commit(self):
 
             if self._mask is not None:
                 scores = np.full(shape=selectedmask.shape,
-                                    fill_value=np.nan)
+                                 fill_value=np.nan)
                 scores[~self._mask] = self._silhouette
             else:
                 scores = self._silhouette
@@ -589,13 +589,15 @@ def clear(self):
 
     def __setup(self):
         # Setup the subwidgets/groups/layout
-        smax = max((np.max(g.scores) for g in self.__groups
+        smax = max((np.nanmax(g.scores) for g in self.__groups
                     if g.scores.size),
                    default=1)
+        smax = 1 if np.isnan(smax) else smax
 
-        smin = min((np.min(g.scores) for g in self.__groups
+        smin = min((np.nanmin(g.scores) for g in self.__groups
                     if g.scores.size),
                    default=-1)
+        smin = -1 if np.isnan(smin) else smin
         smin = min(smin, 0)
 
         font = self.font()

Orange/widgets/visualize/tests/test_owsilhouetteplot.py

@@ -1,3 +1,4 @@
+# pylint: disable=protected-access
 # Test methods with long descriptive names can omit docstrings
 # pylint: disable=missing-docstring
 import random
@@ -6,6 +7,7 @@
 import numpy as np
 
 import Orange.data
+from Orange.data import Table, Domain, ContinuousVariable, DiscreteVariable
 from Orange.widgets.utils.annotated_data import ANNOTATED_DATA_SIGNAL_NAME
 from Orange.widgets.visualize.owsilhouetteplot import OWSilhouettePlot
 from Orange.widgets.tests.base import WidgetTest, WidgetOutputsTestMixin
@@ -105,3 +107,21 @@ def test_memory_error(self):
             self.widget._effective_data = data
             self.widget._update()
             self.assertTrue(self.widget.Error.memory_error.is_shown())
+
+    def test_bad_data_range(self):
+        """
+        Silhouette Plot now sets axis range properly.
+        GH-2377
+        """
+        nan = np.NaN
+        table = Table(
+            Domain(
+                [ContinuousVariable("a"), ContinuousVariable("b"), ContinuousVariable("c")],
+                [DiscreteVariable("d", values=["y", "n"])]),
+            list(zip([4, nan, nan],
+                     [15, nan, nan],
+                     [16, nan, nan],
+                     "nyy"))
+        )
+        self.widget.controls.add_scores.setChecked(1)
+        self.send_signal(self.widget.Inputs.data, table)