Lint

Author: kernc

Orange/widgets/visualize/owvenndiagram.py

@@ -173,9 +173,9 @@ def handleNewSignals(self):
         self.samedomain = samedomain
 
         has_identifiers = all(source_attributes(input.table.domain)
-                                    for input in self.data.values())
+                              for input in self.data.values())
         has_any_identifiers = any(source_attributes(input.table.domain)
-                                    for input in self.data.values())
+                                  for input in self.data.values())
         self.useequalityButton.setEnabled(samedomain)
         self.useidentifiersButton.setEnabled(
             has_any_identifiers or len(self.data) == 0)
@@ -715,7 +715,7 @@ def table_concat(tables):
 
     domain = Orange.data.Domain(attributes, class_vars, metas)
 
-    tables = list(map(lambda tab: tab.transform(domain), tables))
+    tables = [tab.transform(domain) for tab in tables]
     return tables[0].concatenate(tables, axis=0)
 
 
@@ -785,7 +785,7 @@ def inst_key(inst, vars):
     # each instance in this list belongs to one group (but not all
     # groups need to be present).
     inst_by_id = defaultdict(list)
-    id_by_inst = defaultdict(list) # inverse mapping
+    id_by_inst = defaultdict(list)  # inverse mapping
 
     for i in range(len(table)):
         inst_id = instance_ids[i]
@@ -836,8 +836,8 @@ def expanded(feat):
         if var in idvarlist or var in in_expanded:
             continue
         col, _ = newtable.get_column_view(var)
-        nan_indices = filter(lambda j: isinstance(col[j], str) or numpy.isnan(col[j]),
-                             col.nonzero()[0])
+        nan_indices = (i for i in col.nonzero()[0]
+                       if isinstance(col[i]) or numpy.isnan(col[i]))
         for i in nan_indices:
             for ind in inst_by_id[ids[i]]:
                 if not numpy.isnan(table[ind, var]):
@@ -936,8 +936,7 @@ def string_attributes(domain):
     """
     Return all string attributes from the domain.
     """
-    return [attr for attr in domain.variables + domain.metas
-            if attr.is_string]
+    return [attr for attr in domain.variables + domain.metas if attr.is_string]
 
 
 def discrete_attributes(domain):

Orange/widgets/visualize/tests/test_owvenndiagram.py

@@ -76,7 +76,8 @@ def test_venn_diagram(self):
                       source_var, item_id_var)
             temp_m = np.array([[cv[0, i], sources[i], table.metas[0 + i, 0]],
                                [cv[1, i], sources[i], table.metas[1 + i, 0]],
-                               [cv[2, i], sources[i], table.metas[2 + i, 0]]], dtype=object)
+                               [cv[2, i], sources[i], table.metas[2 + i, 0]]],
+                              dtype=object)
             temp_table = self.add_metas(temp_table, temp_d, temp_m)
             tables.append(temp_table)