Skip to content

Commit 49188ee

Browse files
OWSVM: Fix failing tests due to problem_specific params
It is necessary to specify which problem type any param on the learner is valid for, and I had forgotten to do this for the SVM learner. This fixes that.
1 parent bab229f commit 49188ee

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

Orange/widgets/regression/tests/test_owsvmregression.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,10 @@ def setter(value):
2828
gamma_spin.setValue(value)
2929

3030
self.parameters = [
31-
ParameterMapping("C", self.widget.C_spin),
32-
ParameterMapping("epsilon", self.widget.epsilon_spin),
31+
ParameterMapping("C", self.widget.C_spin,
32+
problem_type="regression"),
33+
ParameterMapping("epsilon", self.widget.epsilon_spin,
34+
problem_type="regression"),
3335
ParameterMapping("gamma", self.widget._kernel_params[0],
3436
values=values, setter=setter, getter=getter),
3537
ParameterMapping("coef0", self.widget._kernel_params[1]),
@@ -44,8 +46,10 @@ def test_parameters_svr_type(self):
4446
# setChecked(True) does not trigger callback event
4547
self.widget.nu_radio.click()
4648
self.assertEqual(self.widget.svm_type, OWSVM.Nu_SVM)
47-
self.parameters[0] = ParameterMapping("C", self.widget.nu_C_spin)
48-
self.parameters[1] = ParameterMapping("nu", self.widget.nu_spin)
49+
self.parameters[0] = ParameterMapping("C", self.widget.nu_C_spin,
50+
problem_type="regression")
51+
self.parameters[1] = ParameterMapping("nu", self.widget.nu_spin,
52+
problem_type="regression")
4953
self.test_parameters()
5054

5155
def test_kernel_equation(self):

0 commit comments

Comments
 (0)