Skip to content

Commit 4b84b39

Browse files
authored
Merge pull request #4747 from PrimozGodec/fix-filenametoolong
[FIX] UrlReader: shorten TempFile extension
2 parents 8fe4860 + 96c3fd4 commit 4b84b39

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

Orange/data/io.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import contextlib
22
import csv
33
import locale
4+
import os
45
import pickle
56
import re
67
import sys
@@ -399,7 +400,8 @@ def read(self):
399400
self.filename = self._trim(self._resolve_redirects(self.filename))
400401
with contextlib.closing(self.urlopen(self.filename)) as response:
401402
name = self._suggest_filename(response.headers['content-disposition'])
402-
with NamedTemporaryFile(suffix=name, delete=False) as f:
403+
extension = os.path.splitext(name)[1] # get only file extension
404+
with NamedTemporaryFile(suffix=extension, delete=False) as f:
403405
f.write(response.read())
404406
# delete=False is a workaround for https://bugs.python.org/issue14243
405407

0 commit comments

Comments
 (0)