Skip to content

Commit 53262f5

Browse files
committed
test_owfile: Simplify test
FileWidget catches all exceptions
1 parent 298dea9 commit 53262f5

File tree

1 file changed

+3
-9
lines changed

1 file changed

+3
-9
lines changed

Orange/widgets/data/tests/test_owfile.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -275,17 +275,11 @@ def test_domain_editor_conversions(self):
275275
self.assertAlmostEqual(float(data1[0][2].value), data2[0][1])
276276

277277
def test_url_no_scheme(self):
278-
class SkipRest(Exception):
279-
pass
280-
281-
mock_urlreader = Mock(side_effect=SkipRest())
278+
mock_urlreader = Mock(side_effect=ValueError())
282279
url = 'foo.bar/xxx.csv'
283280

284281
with patch('Orange.widgets.data.owfile.UrlReader', mock_urlreader):
285-
try:
286-
self.widget.url_combo.insertItem(0, url)
287-
self.widget.url_combo.activated.emit(0)
288-
except SkipRest:
289-
pass
282+
self.widget.url_combo.insertItem(0, url)
283+
self.widget.url_combo.activated.emit(0)
290284

291285
mock_urlreader.assert_called_once_with('http://' + url)

0 commit comments

Comments
 (0)