Merge pull request #7091 from biolab/thicker-slider

[ENH] SliderGraph: thicker threshold line

Author: janezd

Orange/widgets/utils/slidergraph.py

@@ -7,6 +7,34 @@
 from Orange.widgets.visualize.utils.plotutils import PlotWidget
 
 
+class InteractiveInfiniteLine(InfiniteLine):  # pylint: disable=abstract-method
+    """
+    A subclass of InfiniteLine that provides custom hover behavior.
+    """
+
+    def __init__(self, angle=90, pos=None, movable=False, bounds=None,
+                 normal_pen=None, highlight_pen=None, **kwargs):
+        super().__init__(angle=angle, pos=pos, movable=movable, bounds=bounds, **kwargs)
+        self._normal_pen = normal_pen
+        self._highlight_pen = highlight_pen
+        self.setPen(normal_pen)
+
+    def hoverEvent(self, ev):
+        """
+        Override hoverEvent to provide custom hover behavior.
+
+        Parameters
+        ----------
+        ev : HoverEvent
+            The hover event from pyqtgraph
+        """
+
+        if ev.isEnter() and self._highlight_pen is not None:
+            self.setPen(self._highlight_pen)
+        elif ev.isExit() and self._normal_pen is not None:
+            self.setPen(self._normal_pen)
+
+
 class SliderGraph(PlotWidget):
     """
     An widget graph element that shows a line plot with more sequences. It
@@ -136,14 +164,23 @@ def _plot_cutpoint(self, x):
             self._line = None
             return
         if self._line is None:
-            # plot interactive vertical line
-            self._line = InfiniteLine(
+            normal_pen = mkPen(
+                self.palette().text().color(), width=4,
+                style=Qt.SolidLine, capStyle=Qt.RoundCap
+            )
+            highlight_pen = mkPen(
+                self.palette().link().color(), width=4,
+                style=Qt.SolidLine, capStyle=Qt.RoundCap
+            )
+
+            self._line = InteractiveInfiniteLine(
                 angle=90, pos=x, movable=True,
                 bounds=self.selection_limit if self.selection_limit is not None
-                else (self.x.min(), self.x.max())
+                    else (self.x.min(), self.x.max()),
+                normal_pen=normal_pen,
+                highlight_pen=highlight_pen
             )
             self._line.setCursor(Qt.SizeHorCursor)
-            self._line.setPen(mkPen(self.palette().text().color(), width=2))
             self._line.sigPositionChanged.connect(self._on_cut_changed)
             self.addItem(self._line)
         else:

Orange/widgets/utils/tests/test_slidergraph.py

@@ -1,3 +1,5 @@
+from unittest.mock import Mock
+
 import numpy as np
 from AnyQt.QtCore import Qt
 
@@ -105,3 +107,25 @@ def test_plot_no_cutpoint(self):
         p.update(x, self.data, [Qt.red])
         # pylint: disable=protected-access
         self.assertIsNone(p._line)
+
+    def test_hover_event(self):
+        p = self.widget.plot
+        x = np.arange(len(self.data[0]))
+        p.update(x, self.data, [Qt.red], cutpoint_x=1)
+
+        # pylint: disable=protected-access
+        self.assertIsNotNone(p._line)
+
+        enter_event = Mock()
+        enter_event.isEnter.return_value = True
+        enter_event.isExit.return_value = False
+
+        p._line.hoverEvent(enter_event)
+        self.assertEqual(p._line.pen, p._line._highlight_pen)
+
+        exit_event = Mock()
+        exit_event.isEnter.return_value = False
+        exit_event.isExit.return_value = True
+
+        p._line.hoverEvent(exit_event)
+        self.assertEqual(p._line.pen, p._line._normal_pen)