Skip to content

Commit 6ff92d0

Browse files
Venn: Update tests
Co-authored-by: Andreja Kovacic <kovacic.andreja@gmail.com>
1 parent 2631135 commit 6ff92d0

File tree

2 files changed

+15
-14
lines changed

2 files changed

+15
-14
lines changed

Orange/widgets/visualize/owvenndiagram.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ class Error(widget.OWWidget.Error):
7171
#: or preserve all duplicates in the output.
7272
output_duplicates = settings.Setting(False)
7373
autocommit = settings.Setting(True)
74-
rowwise = settings.Setting(False)
74+
rowwise = settings.Setting(True)
7575
selected_feature = settings.ContextSetting(None)
7676

7777
want_control_area = False
@@ -495,10 +495,9 @@ def match(val):
495495
if not len(input.table):
496496
continue
497497
if self.selected_feature is not None:
498-
if self.selected_feature is not None:
499-
mask = list(map(match, (inst[self.selected_feature] for inst in input.table)))
500-
else:
501-
mask = [False] * len(input.table)
498+
mask = list(map(match,
499+
(inst[self.selected_feature]
500+
for inst in input.table)))
502501

503502
def instance_key(inst):
504503
return str(inst[self.selected_feature])

Orange/widgets/visualize/tests/test_owvenndiagram.py

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -126,6 +126,7 @@ def _select_data(self):
126126

127127
def test_multiple_input(self):
128128
"""Over rows"""
129+
self.widget.rowwise = True
129130
self.send_signal(self.signal_name, self.data[:100], 1)
130131
self.send_signal(self.signal_name, self.data[50:], 2)
131132

@@ -164,7 +165,7 @@ def test_multiple_input(self):
164165
self.assertIsNone(self.get_output(self.widget.Outputs.annotated_data))
165166

166167
def test_multiple_input_over_cols(self):
167-
self.widget.usecols = True
168+
self.widget.rowwise = False
168169
selected_atr_name = 'Selected'
169170
input2 = self.data.transform(Domain([self.data.domain.attributes[0]],
170171
self.data.domain.class_vars,
@@ -234,7 +235,7 @@ def test_unconditional_commit_on_new_signal(self):
234235
commit.assert_called()
235236

236237
def test_input_compatibility(self):
237-
self.widget.usecols = False
238+
self.widget.rowwise = True
238239
self.send_signal(self.signal_name, self.data, 1)
239240
self.send_signal(self.signal_name,
240241
self.data.transform(Domain([self.data.domain.attributes[0]],
@@ -243,7 +244,7 @@ def test_input_compatibility(self):
243244
self.assertTrue(self.widget.Error.domain_mismatch.is_shown())
244245
self.assertFalse(self.widget.Error.instances_mismatch.is_shown())
245246

246-
self.widget.usecols = True
247+
self.widget.rowwise = False
247248
self.send_signal(self.signal_name, self.data[:100, :], 2)
248249
self.assertTrue(self.widget.Error.instances_mismatch.is_shown())
249250
self.assertFalse(self.widget.Error.domain_mismatch.is_shown())
@@ -257,32 +258,33 @@ def test_input_compatibility(self):
257258
self.assertIsNone(self.get_output(self.widget.Outputs.annotated_data))
258259

259260
def test_rows_identifiers(self):
260-
self.widget.usecols = False
261-
self.widget.useidentifiers = True
261+
self.widget.rowwise = True
262262
data = Table('zoo')
263263
self.send_signal(self.signal_name, data, (1, 'Data', None))
264+
self.widget.selected_feature = 'name'
264265
self.send_signal(self.signal_name, data[:5], (2, 'Data', None))
265266

266267
self.assertIsNone(self.get_output(self.widget.Outputs.selected_data))
267268
self.widget.vennwidget.vennareas()[3].setSelected(True)
268269
selected = self.get_output(self.widget.Outputs.selected_data)
269270
self.assertEqual(len(selected), 5)
270-
self.assertEqual(selected.domain, data.domain)
271+
self.assertEqual(selected.domain.attributes, data.domain.attributes)
272+
self.assertEqual(selected.domain.class_vars, data.domain.class_vars)
271273

272274
annotated = self.get_output(self.widget.Outputs.annotated_data)
273275
self.assertEqual(len(annotated), 100)
274276

275-
def test_too_many_outputs(self):
277+
def test_too_many_inputs(self):
276278
self.send_signal(self.signal_name, self.data, 1)
277279
self.send_signal(self.signal_name, self.data, 2)
278280
self.send_signal(self.signal_name, self.data, 3)
279281
self.send_signal(self.signal_name, self.data, 4)
280282
self.send_signal(self.signal_name, self.data, 5)
281283
self.send_signal(self.signal_name, self.data, 6)
282-
self.assertTrue(self.widget.Error.too_many_outputs.is_shown())
284+
self.assertTrue(self.widget.Error.too_many_inputs.is_shown())
283285

284286
self.send_signal(self.signal_name, None, 6)
285-
self.assertFalse(self.widget.Error.too_many_outputs.is_shown())
287+
self.assertFalse(self.widget.Error.too_many_inputs.is_shown())
286288

287289

288290
class GroupTableIndicesTest(unittest.TestCase):

0 commit comments

Comments
 (0)