SklLearner: Correctly restore self.__dict__ for subsequent repr to work

Fixes #2275
patch.object() obviously didn't restore params as expected.

Author: kernc

Orange/base.py

@@ -29,7 +29,7 @@ def __repr__(self):
 class _ReprableWithParams(Reprable):
     def __repr__(self):
         # In addition to saving values onto self, SklLearners save into params
-        with patch.object(self, '__dict__', dict(self.__dict__, **self.params)):
+        with patch.dict(self.__dict__, self.params):
             return super().__repr__()
 
 

Orange/tests/test_util.py

@@ -37,6 +37,7 @@ def test_reprable(self):
         from Orange.data import ContinuousVariable
         from Orange.preprocess.impute import ReplaceUnknownsRandom
         from Orange.statistics.distribution import Continuous
+        from Orange.classification import LogisticRegressionLearner
 
         var = ContinuousVariable('x')
         transform = ReplaceUnknownsRandom(var, Continuous(1, var))
@@ -46,6 +47,11 @@ def test_reprable(self):
                          "variable=ContinuousVariable(name='x', number_of_decimals=3), "
                          "distribution=Continuous([[ 0.], [ 0.]]))")
 
+        # GH 2275
+        logit = LogisticRegressionLearner()
+        for _ in range(2):
+            self.assertEqual(repr(logit), 'LogisticRegressionLearner()')
+
     def test_deepgetattr(self):
         class a:
             l = []