Skip to content

Commit 75b6295

Browse files
committed
concurrent: Remove task.deleteLater calls
Allow PyOwned to fully handle the disposal
1 parent 0fcf78b commit 75b6295

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

Orange/widgets/utils/concurrent.py

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -571,10 +571,6 @@ def __cancel_task(self, wait: bool = True):
571571
self._disconnect_signals(state)
572572
if wait:
573573
concurrent.futures.wait([state.future])
574-
state.deleteLater()
575-
else:
576-
w = FutureWatcher(state.future, parent=state)
577-
w.done.connect(state.deleteLater)
578574

579575
def _connect_signals(self, state: TaskState):
580576
state.partial_result_ready.connect(self.on_partial_result)
@@ -590,7 +586,6 @@ def _on_task_done(self, future: Future):
590586
assert self.__task.future is future
591587
assert self.__task.watcher.future() is future
592588
self.__task, task = None, self.__task
593-
task.deleteLater()
594589
ex = future.exception()
595590
if ex is not None:
596591
self.on_exception(ex)

0 commit comments

Comments
 (0)