Deprecation warning when predict uses predict_storage fallback

Author: markotoplak

Orange/base.py

@@ -229,6 +229,9 @@ def predict(self, X):
         if type(self).predict_storage is Model.predict_storage:
             raise TypeError("Descendants of Model must overload method predict")
         else:
+            warnings.warn("Automatic fallback to predict_storage will be removed in 3.36. "
+                          "All models need to implement predict.",
+                          OrangeDeprecationWarning)
             Y = np.zeros((len(X), len(self.domain.class_vars)))
             Y[:] = np.nan
             table = Table(self.domain, X, Y)

Orange/classification/tests/test_base.py

@@ -1,7 +1,9 @@
 import unittest
+from distutils.version import LooseVersion
 
 import numpy as np
 
+import Orange
 from Orange.data import Table, DiscreteVariable, Domain
 from Orange.classification import LogisticRegressionLearner, TreeLearner
 
@@ -199,6 +201,12 @@ def test_sparse_matrix(self):
             pred = model(iris_sparse.X.tocoo())
             self.assertTupleEqual((len(self.iris),), pred.shape)
 
+    def test_remove_default_predict(self):
+        if LooseVersion(Orange.__version__) >= LooseVersion("3.36"):
+            self.fail(
+                "Orange 3.35 deprecated predict() thorugh predict_storage. "
+                "Rewrite Model.predict to raise NotImplementedError.")
+
 
 if __name__ == '__main__':
     unittest.main()