Merge pull request #1947 from VesnaT/fix_owheatmap

OWHeatMap: Fix crash when data is one instance or one feature
(cherry picked from commit ece0ee7)

Author: astaric

Orange/widgets/visualize/owheatmap.py

@@ -476,6 +476,10 @@ class Information(widget.OWWidget.Information):
 
     class Error(widget.OWWidget.Error):
         no_continuous = Msg("No continuous feature columns")
+        not_enough_features = Msg("Not enough features for column clustering")
+        not_enough_instances = Msg("Not enough instances")
+        not_enough_instances_k_means = Msg(
+            "Not enough instances for k-means merging")
         not_enough_memory = Msg("Not enough memory to show this data")
 
     class Warning(widget.OWWidget.Warning):
@@ -753,10 +757,22 @@ def set_dataset(self, data=None):
     def update_heatmaps(self):
         if self.data is not None:
             self.clear_scene()
-            self.construct_heatmaps(self.data)
-            self.construct_heatmaps_scene(
-                self.heatmapparts, self.effective_data)
-            self.selected_rows = []
+            self.clear_messages()
+            if self.sort_columns not in (OWHeatMap.NoSorting,) and \
+                    len(self.data.domain.attributes) < 2:
+                self.Error.not_enough_features()
+            elif (self.sort_columns not in (OWHeatMap.NoSorting,) or
+                    self.sort_rows not in (OWHeatMap.NoSorting,
+                                           OWHeatMap.SortBarycenter)) and \
+                    len(self.data) < 2:
+                self.Error.not_enough_instances()
+            elif self.merge_kmeans and len(self.data) < 3:
+                self.Error.not_enough_instances_k_means()
+            else:
+                self.construct_heatmaps(self.data)
+                self.construct_heatmaps_scene(
+                    self.heatmapparts, self.effective_data)
+                self.selected_rows = []
         else:
             self.clear()
         self.commit()
@@ -1423,12 +1439,10 @@ def update_color_schema(self):
             legend.set_color_table(palette)
 
     def update_sorting_examples(self):
-        if self.effective_data is not None:
-            self.update_heatmaps()
+        self.update_heatmaps()
 
     def update_sorting_attributes(self):
-        if self.effective_data is not None:
-            self.update_heatmaps()
+        self.update_heatmaps()
 
     def update_legend(self):
         for item in self.heatmap_scene.items():
@@ -1538,7 +1552,6 @@ def commit(self):
         data = None
         indices = None
         if self.merge_kmeans:
-            assert self.merge_indices is not None
             merge_indices = self.merge_indices
         else:
             merge_indices = None

Orange/widgets/visualize/tests/test_owheatmap.py

@@ -1,6 +1,8 @@
 # Test methods with long descriptive names can omit docstrings
 # pylint: disable=missing-docstring
-from Orange.data import Table
+import numpy as np
+
+from Orange.data import Table, Domain, DiscreteVariable, ContinuousVariable
 from Orange.preprocess import Continuize
 from Orange.widgets.visualize.owheatmap import OWHeatMap
 from Orange.widgets.tests.base import WidgetTest, WidgetOutputsTestMixin
@@ -74,3 +76,33 @@ def _select_data(self):
         self.widget.selection_manager.select_rows(selected_indices)
         self.widget.on_selection_finished()
         return selected_indices
+
+    def test_not_enough_data_settings_changed(self):
+        """Check widget for dataset with one feature or for one instance"""
+        self._test_helper()
+        self.widget.controls.merge_kmeans.setChecked(True)
+        self._test_helper(True)
+
+    def _test_helper(self, checked=False):
+        iris = Table("iris")
+        msg = self.widget.Error
+        for i in range(0, self.widget.colsortcb.count()):
+            self.widget.colsortcb.activated.emit(i)
+            self.widget.colsortcb.setCurrentIndex(i)
+            self.send_signal("Data", None)
+            self.send_signal("Data", iris[:, 0])
+            if i > 0:
+                self.assertTrue(msg.not_enough_features.is_shown())
+            for j in range(0, self.widget.rowsortcb.count()):
+                self.widget.rowsortcb.activated.emit(j)
+                self.widget.rowsortcb.setCurrentIndex(j)
+                self.send_signal("Data", None)
+                self.send_signal("Data", iris[0:1])
+                if j > 1:
+                    self.assertTrue(msg.not_enough_instances.is_shown())
+                elif checked and j > 1:
+                    self.assertTrue(msg.not_enough_instances_k_means.is_shown())
+        self.send_signal("Data", None)
+        self.assertFalse(msg.not_enough_features.is_shown())
+        self.assertFalse(msg.not_enough_instances.is_shown())
+        self.assertFalse(msg.not_enough_instances_k_means.is_shown())