Scatterplot: Enable/disable vizrank button

Author: VesnaT

Orange/widgets/visualize/owscatterplot.py

@@ -43,7 +43,7 @@ def initialize(self):
 
     def check_preconditions(self):
         self.Information.add_message(
-            "color_required", "Color variable must be selected")
+            "color_required", "Color variable is not selected")
         self.Information.color_required.clear()
         if not super().check_preconditions():
             return False
@@ -301,16 +301,20 @@ def effective_variables(self):
 
     def _vizrank_color_change(self):
         self.vizrank.initialize()
-        is_enabled = self.data is not None and not self.data.is_sparse() and \
-            len(self.xy_model) > 2 and len(self.data[self.valid_data]) > 1 \
-            and np.all(np.nan_to_num(np.nanstd(self.data.X, 0)) != 0)
-        self.vizrank_button.setEnabled(
-            is_enabled and self.attr_color is not None and
-            not np.isnan(self.data.get_column_view(
-                self.attr_color)[0].astype(float)).all())
-        text = "Color variable has to be selected." \
-            if is_enabled and self.attr_color is None else ""
-        self.vizrank_button.setToolTip(text)
+        err_msg = ""
+        if self.data is None:
+            err_msg = "No data on input"
+        elif self.data.is_sparse():
+            err_msg = "Data is sparse"
+        elif len(self.xy_model) < 3:
+            err_msg = "Not enough features for ranking"
+        elif self.attr_color is None:
+            err_msg = "Color variable is not selected"
+        elif np.isnan(self.data.get_column_view(
+                self.attr_color)[0].astype(float)).all():
+            err_msg = "Color variable has no values"
+        self.vizrank_button.setEnabled(not err_msg)
+        self.vizrank_button.setToolTip(err_msg)
 
     def set_data(self, data):
         super().set_data(data)

Orange/widgets/visualize/tests/test_owscatterplot.py

@@ -397,6 +397,61 @@ def test_vizrank_nonprimitives(self):
                    new=lambda *_1, **_2: lambda data: np.arange(len(data))):
             self.widget.vizrank.score_heuristic()
 
+    def test_vizrank_enabled(self):
+        self.send_signal(self.widget.Inputs.data, self.data)
+        self.assertTrue(self.widget.vizrank_button.isEnabled())
+        self.assertEqual(self.widget.vizrank_button.toolTip(), "")
+        self.assertTrue(self.widget.vizrank.button.isEnabled())
+        self.widget.vizrank.button.click()
+
+    def test_vizrank_enabled_no_data(self):
+        self.send_signal(self.widget.Inputs.data, None)
+        self.assertFalse(self.widget.vizrank_button.isEnabled())
+        self.assertEqual(self.widget.vizrank_button.toolTip(), "No data on input")
+
+    def test_vizrank_enabled_sparse_data(self):
+        self.send_signal(self.widget.Inputs.data, self.data.to_sparse())
+        self.assertFalse(self.widget.vizrank_button.isEnabled())
+        self.assertEqual(self.widget.vizrank_button.toolTip(), "Data is sparse")
+
+    def test_vizrank_enabled_constant_data(self):
+        domain = Domain([ContinuousVariable("c1"),
+                         ContinuousVariable("c2"),
+                         ContinuousVariable("c3"),
+                         ContinuousVariable("c4")],
+                        DiscreteVariable("cls", values=["a", "b"]))
+        X = np.zeros((10, 4))
+        table = Table(domain, X, np.random.randint(2, size=10))
+        self.send_signal(self.widget.Inputs.data, table)
+        self.assertEqual(self.widget.vizrank_button.toolTip(), "")
+        self.assertTrue(self.widget.vizrank_button.isEnabled())
+        self.assertTrue(self.widget.vizrank.button.isEnabled())
+        self.widget.vizrank.button.click()
+
+    def test_vizrank_enabled_two_features(self):
+        self.send_signal(self.widget.Inputs.data, self.data[:, 2:])
+        self.assertFalse(self.widget.vizrank_button.isEnabled())
+        self.assertEqual(self.widget.vizrank_button.toolTip(),
+                         "Not enough features for ranking")
+
+    def test_vizrank_enabled_no_color_var(self):
+        self.send_signal(self.widget.Inputs.data, self.data[:, :3])
+        self.assertFalse(self.widget.vizrank_button.isEnabled())
+        self.assertEqual(self.widget.vizrank_button.toolTip(),
+                         "Color variable is not selected")
+
+    def test_vizrank_enabled_color_var_nans(self):
+        domain = Domain([ContinuousVariable("c1"),
+                         ContinuousVariable("c2"),
+                         ContinuousVariable("c3"),
+                         ContinuousVariable("c4")],
+                        DiscreteVariable("cls", values=["a", "b"]))
+        table = Table(domain, np.random.random((10, 4)), np.full(10, np.nan))
+        self.send_signal(self.widget.Inputs.data, table)
+        self.assertFalse(self.widget.vizrank_button.isEnabled())
+        self.assertEqual(self.widget.vizrank_button.toolTip(),
+                         "Color variable has no values")
+
     def test_auto_send_selection(self):
         """
         Scatter Plot automatically sends selection only when the checkbox Send automatically