Merge pull request #2428 from jerneju/show-probabilities-distributions

[FIX] Distributions: show probabilities upon selection

Author: lanzagar

Orange/widgets/visualize/owdistributions.py

@@ -220,6 +220,8 @@ def set_data(self, data):
         self.clear()
         self.warning()
         self.data = data
+        self.distributions = None
+        self.contingencies = None
         if self.data is not None:
             if not self.data:
                 self.warning("Empty input data cannot be visualized")
@@ -332,7 +334,7 @@ def help_event(self, ev):
     def display_distribution(self):
         dist = self.distributions
         var = self.var
-        if not len(dist):
+        if dist is None or not len(dist):
             return
         self.plot.clear()
         self.plot_prob.clear()
@@ -371,8 +373,6 @@ def display_distribution(self):
                 self.tooltip_items.append((self.plot, item))
 
     def _on_relative_freq_changed(self):
-        if not self.distributions:
-            return
         self.set_left_axis_name()
         if self.cvar and self.cvar.is_discrete:
             self.display_contingency()
@@ -386,7 +386,7 @@ def display_contingency(self):
         """
         cont = self.contingencies
         var, cvar = self.var, self.cvar
-        if not len(cont):
+        if cont is None or not len(cont):
             return
         self.plot.clear()
         self.plot_prob.clear()

Orange/widgets/visualize/tests/test_owdistributions.py

@@ -73,6 +73,13 @@ def test_no_distributions(self):
         Do not fail when there is no data and when sb clicks
         "Show relative frequencies".
         GH-2383
+        GH-2428
         """
         self.send_signal(self.widget.Inputs.data, None)
         self.widget.cb_rel_freq.click()
+        self.send_signal(self.widget.Inputs.data, self.data)
+        self.widget.cb_rel_freq.setChecked(False)
+        self.widget.cb_rel_freq.click()
+        self.send_signal(self.widget.Inputs.data, None)
+        self.widget.cb_rel_freq.setChecked(True)
+        self.widget.cb_rel_freq.click()