OWLinePlot: data info displayed in the status bar

Author: aturanjanin

Orange/widgets/visualize/owlineplot.py

@@ -25,6 +25,7 @@
 from Orange.widgets.utils.plot import OWPlotGUI, SELECT, PANNING, ZOOMING
 from Orange.widgets.utils.sql import check_sql_input
 from Orange.widgets.utils.widgetpreview import WidgetPreview
+from Orange.widgets.utils.state_summary import format_summary_details
 from Orange.widgets.visualize.owdistributions import LegendItem
 from Orange.widgets.widget import OWWidget, Input, Output, Msg
 
@@ -475,8 +476,6 @@ def _add_graph(self):
         box.layout().addWidget(self.graph)
 
     def _add_controls(self):
-        infobox = gui.widgetBox(self.controlArea, "Info")
-        self.infoLabel = gui.widgetLabel(infobox, "No data on input.")
         displaybox = gui.widgetBox(self.controlArea, "Display")
         gui.checkBox(displaybox, self, "show_profiles", "Lines",
                      callback=self.__show_profiles_changed,
@@ -505,6 +504,9 @@ def _add_controls(self):
         gui.rubber(self.controlArea)
         gui.auto_send(self.controlArea, self, "auto_commit")
 
+        self.info.set_input_summary(self.info.NoInput)
+        self.info.set_output_summary(self.info.NoOutput)
+
     def __show_profiles_changed(self):
         self.check_display_options()
         self._update_visibility("profiles")
@@ -534,6 +536,7 @@ def __group_var_changed(self):
     def set_data(self, data):
         self.closeContext()
         self.data = data
+        self._set_input_summary()
         self.clear()
         self.check_data()
         self.check_display_options()
@@ -555,8 +558,6 @@ def error(err):
 
         self.clear_messages()
         if self.data is not None:
-            self.infoLabel.setText("%i instances on input\n%i features" % (
-                len(self.data), len(self.data.domain.attributes)))
             self.graph_variables = [var for var in self.data.domain.attributes
                                     if var.is_continuous]
             self.valid_data = ~countnans(self.data.X, axis=1).astype(bool)
@@ -580,6 +581,11 @@ def check_display_options(self):
                 len(self.data[self.valid_data]) < SEL_MAX_INSTANCES
             self.enable_selection.emit(enable)
 
+    def _set_input_summary(self):
+        summary = len(self.data) if self.data else self.info.NoInput
+        details = format_summary_details(self.data) if self.data else ""
+        self.info.set_input_summary(summary, details)
+
     @Inputs.data_subset
     @check_sql_input
     def set_subset_data(self, subset):
@@ -733,6 +739,10 @@ def commit(self):
         selected = self.data[self.selection] \
             if self.data is not None and bool(self.selection) else None
         annotated = create_annotated_table(self.data, self.selection)
+
+        summary = len(selected) if selected else self.info.NoOutput
+        details = format_summary_details(selected) if selected else ""
+        self.info.set_output_summary(summary, details)
         self.Outputs.selected_data.send(selected)
         self.Outputs.annotated_data.send(annotated)
 
@@ -754,7 +764,6 @@ def clear(self):
         self.__groups = []
         self.graph_variables = []
         self.graph.reset()
-        self.infoLabel.setText("No data on input.")
         self.group_vars.set_domain(None)
         self.group_view.setEnabled(False)
 

Orange/widgets/visualize/tests/test_owlineplot.py

@@ -19,6 +19,7 @@
 from Orange.widgets.visualize.owlineplot import (
     OWLinePlot, ccw, intersects, line_intersects_profiles
 )
+from Orange.widgets.utils.state_summary import format_summary_details
 
 
 class TestOWLinePLot(WidgetTest, WidgetOutputsTestMixin):
@@ -42,13 +43,13 @@ def _select_data(self):
         return self.widget.selection
 
     def test_input_data(self):
-        no_data_info = "No data on input."
-        self.assertEqual(self.widget.infoLabel.text(), no_data_info)
+        no_data = "No data on input"
+        self.assertEqual(self.widget.info._StateInfo__input_summary.details, no_data)
         self.send_signal(self.widget.Inputs.data, self.data)
         self.assertEqual(self.widget.group_view.model().rowCount(), 2)
         self.send_signal(self.widget.Inputs.data, None)
         self.assertEqual(self.widget.group_view.model().rowCount(), 1)
-        self.assertEqual(self.widget.infoLabel.text(), no_data_info)
+        self.assertEqual(self.widget.info._StateInfo__input_summary.details, no_data)
 
     def test_input_continuous_class(self):
         self.send_signal(self.widget.Inputs.data, self.housing)
@@ -279,6 +280,32 @@ def test_unconditional_commit_on_new_signal(self):
             self.send_signal(self.widget.Inputs.data, self.titanic)
             commit.assert_called()
 
+    def test_summary(self):
+        """Check if status bar is updated when data is received"""
+        info = self.widget.info
+        no_input, no_output = "No data on input", "No data on output"
+
+        data = self.housing
+        self.send_signal(self.widget.Inputs.data, data)
+        summary, details = f"{len(data)}", format_summary_details(data)
+        self.assertEqual(info._StateInfo__input_summary.brief, summary)
+        self.assertEqual(info._StateInfo__input_summary.details, details)
+        self.assertEqual(info._StateInfo__output_summary.brief, "")
+        self.assertEqual(info._StateInfo__output_summary.details, no_output)
+
+        sel_indices = list(range(5))
+        self.widget.selection_changed(sel_indices)
+        output = self.get_output(self.widget.Outputs.selected_data)
+        summary, details = f"{len(output)}", format_summary_details(output)
+        self.assertEqual(info._StateInfo__output_summary.brief, summary)
+        self.assertEqual(info._StateInfo__output_summary.details, details)
+
+        self.send_signal(self.widget.Inputs.data, None)
+        self.assertEqual(info._StateInfo__input_summary.brief, "")
+        self.assertEqual(info._StateInfo__input_summary.details, no_input)
+        self.assertEqual(info._StateInfo__output_summary.brief, "")
+        self.assertEqual(info._StateInfo__output_summary.details, no_output)
+
 
 class TestSegmentsIntersection(unittest.TestCase):
     def test_ccw(self):