Skip to content

Commit 9a984b7

Browse files
committed
Data info displayed in the status bar
1 parent 4462394 commit 9a984b7

File tree

2 files changed

+19
-7
lines changed

2 files changed

+19
-7
lines changed

Orange/widgets/data/owdatasampler.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@
1111
from Orange.data import Table
1212
from Orange.data.sql.table import SqlTable
1313
from Orange.widgets.utils.widgetpreview import WidgetPreview
14+
from Orange.widgets.utils.state_summary import format_summary_details
1415
from Orange.widgets.widget import Msg, OWWidget, Input, Output
1516
from Orange.util import Reprable
1617

@@ -179,14 +180,14 @@ def set_data(self, dataset):
179180
self.cb_seed.setVisible(not sql)
180181
self.cb_stratify.setVisible(not sql)
181182
self.cb_sql_dl.setVisible(sql)
182-
self.info.set_input_summary(str(len(dataset)))
183+
self.info.set_input_summary(len(dataset),
184+
format_summary_details(dataset))
183185

184186
if not sql:
185187
self._update_sample_max_size()
186188
self.updateindices()
187189
else:
188190
self.info.set_input_summary(self.info.NoInput)
189-
self.info.set_output_summary(self.info.NoInput)
190191
self.indices = None
191192
self.clear_messages()
192193
self.commit()
@@ -224,12 +225,16 @@ def commit(self):
224225
remaining, sample = self.indices
225226
elif self.sampling_type == self.CrossValidation:
226227
remaining, sample = self.indices[self.selectedFold - 1]
227-
self.info.set_output_summary(str(len(sample)))
228228

229229
sample = self.data[sample]
230230
other = self.data[remaining]
231231
self.sampled_instances = len(sample)
232232
self.remaining_instances = len(other)
233+
234+
summary = len(sample) if sample else self.info.NoOutput
235+
details = format_summary_details(sample) if sample else ""
236+
self.info.set_output_summary(summary, details)
237+
233238
self.Outputs.data_sample.send(sample)
234239
self.Outputs.remaining_data.send(other)
235240

Orange/widgets/data/tests/test_owdatasampler.py

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
from Orange.data import Table
66
from Orange.widgets.data.owdatasampler import OWDataSampler
77
from Orange.widgets.tests.base import WidgetTest
8+
from Orange.widgets.utils.state_summary import format_summary_details
89

910

1011
class TestOWDataSampler(WidgetTest):
@@ -126,17 +127,23 @@ def test_shuffling(self):
126127

127128
def test_summary(self):
128129
"""Check if status bar is updated when data is received"""
129-
input_sum = self.widget.info.set_input_summary = Mock()
130130
data = self.iris
131+
input_sum = self.widget.info.set_input_summary = Mock()
132+
output_sum = self.widget.info.set_output_summary = Mock()
131133

132-
input_sum.reset_mock()
133-
self.send_signal(self.widget.Inputs.data, data[:])
134-
input_sum.assert_called_with("150")
134+
self.send_signal(self.widget.Inputs.data, data)
135+
input_sum.assert_called_with(len(data), format_summary_details(data))
136+
output = self.get_output(self.widget.Outputs.data_sample)
137+
output_sum.assert_called_with(len(output),
138+
format_summary_details(output))
135139

136140
input_sum.reset_mock()
141+
output_sum.reset_mock()
137142
self.send_signal(self.widget.Inputs.data, None)
138143
input_sum.assert_called_once()
139144
self.assertEqual(input_sum.call_args[0][0].brief, "")
145+
output_sum.assert_called_once()
146+
self.assertEqual(output_sum.call_args[0][0].brief, "")
140147

141148
def set_fixed_sample_size(self, sample_size, with_replacement=False):
142149
"""Set fixed sample size and return the number of gui spin.

0 commit comments

Comments
 (0)