Usage statistics: do not crash at any exception

Author: markotoplak

Orange/canvas/__main__.py

@@ -276,8 +276,13 @@ def send_usage_statistics():
 
     class SendUsageStatistics(QThread):
         def run(self):
-            usage = UsageStatistics()
-            usage.send_statistics()
+            try:
+                usage = UsageStatistics()
+                usage.send_statistics()
+            except Exception:  # pylint: disable=broad-except
+                # unhanled exceptions in threads will crash Orange and nothing
+                # that happens here should
+                log.warning("Failed to send usage statistics.")
 
     thread = SendUsageStatistics()
     thread.start()

Orange/canvas/document/usagestatistics.py

@@ -21,7 +21,7 @@
 
 
 class UsageStatistics:
-    """
+q    """
     Tracks and sends upon close usage statistics when error-reporting/send-statistics is true.
     This option can be changed in the preferences menu.
 
@@ -122,8 +122,6 @@ def send_statistics(self):
                         json.dump([], f)
                 except (ConnectionError, requests.exceptions.RequestException):
                     log.warning("Connection error while attempting to send usage statistics.")
-                except Exception:
-                    log.warning("Failed to send usage statistics.")
 
     def write_statistics(self):
         if not release: