Skip to content

Commit bd72e64

Browse files
committed
Give created QGraphicsScenes a parent
Ensure the scene is deleted at the same time as the widget. Fix an runtime error at process exit when running tests with PyQt 5.14
1 parent dc2ea48 commit bd72e64

File tree

6 files changed

+6
-6
lines changed

6 files changed

+6
-6
lines changed

Orange/widgets/unsupervised/owhierarchicalclustering.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ def on_annotation_changed(value):
266266

267267
gui.auto_send(box, self, "autocommit", box=False)
268268

269-
self.scene = QGraphicsScene()
269+
self.scene = QGraphicsScene(self)
270270
self.view = StickyGraphicsView(
271271
self.scene,
272272
horizontalScrollBarPolicy=Qt.ScrollBarAlwaysOff,

Orange/widgets/visualize/owboxplot.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,7 @@ def __init__(self):
263263
stateWhenDisabled=False)
264264

265265
gui.vBox(self.mainArea, addSpace=True)
266-
self.box_scene = QGraphicsScene()
266+
self.box_scene = QGraphicsScene(self)
267267
self.box_scene.selectionChanged.connect(self.commit)
268268
self.box_view = QGraphicsView(self.box_scene)
269269
self.box_view.setRenderHints(QPainter.Antialiasing |

Orange/widgets/visualize/owmosaic.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,7 @@ def __init__(self):
324324

325325
self.areas = []
326326

327-
self.canvas = QGraphicsScene()
327+
self.canvas = QGraphicsScene(self)
328328
self.canvas_view = ViewWithPress(
329329
self.canvas, handler=self.clear_selection)
330330
self.mainArea.layout().addWidget(self.canvas_view)

Orange/widgets/visualize/owsieve.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ def __init__(self):
121121
self.attr_box, self, "Score Combinations", self.set_attr)
122122
self.vizrank_button.setSizePolicy(*fixed_size)
123123

124-
self.canvas = QGraphicsScene()
124+
self.canvas = QGraphicsScene(self)
125125
self.canvasView = ViewWithPress(
126126
self.canvas, self.mainArea, handler=self.reset_selection)
127127
self.mainArea.layout().addWidget(self.canvasView)

Orange/widgets/visualize/owsilhouetteplot.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,7 @@ def __init__(self):
179179
# Ensure that the controlArea is not narrower than buttonsArea
180180
self.controlArea.layout().addWidget(self.buttonsArea)
181181

182-
self.scene = QGraphicsScene()
182+
self.scene = QGraphicsScene(self)
183183
self.view = StickyGraphicsView(self.scene)
184184
self.view.setRenderHint(QPainter.Antialiasing, True)
185185
self.view.setAlignment(Qt.AlignTop | Qt.AlignLeft)

Orange/widgets/visualize/owvenndiagram.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ def __init__(self):
100100
self.area_keys = []
101101

102102
# Main area view
103-
self.scene = QGraphicsScene()
103+
self.scene = QGraphicsScene(self)
104104
self.view = QGraphicsView(self.scene)
105105
self.view.setRenderHint(QPainter.Antialiasing)
106106
self.view.setBackgroundRole(QPalette.Window)

0 commit comments

Comments
 (0)