Skip to content

Commit bfe44fc

Browse files
VesnaTmarkotoplak
authored andcommitted
ListView: Fix selection
1 parent a395d45 commit bfe44fc

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

Orange/widgets/gui.py

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
is_macstyle
4343
)
4444
from orangewidget.utils.itemmodels import PyTableModel
45+
from orangewidget.utils.listview import ListViewFilter
4546

4647
try:
4748
# Some Orange widgets might expect this here
@@ -192,13 +193,15 @@ def listView(widget, master, value=None, model=None, box=None, callback=None,
192193
else:
193194
bg = widget
194195
view = viewType(preferred_size=sizeHint)
195-
if isinstance(view.model(), QSortFilterProxyModel):
196+
if isinstance(view, ListViewFilter):
196197
view.model().setSourceModel(model)
198+
signal = view.sigSelectionChanged
197199
else:
198200
view.setModel(model)
201+
signal = view.selectionModel().selectionChanged
199202
if value is not None:
200203
connectControl(master, value, callback,
201-
view.selectionModel().selectionChanged,
204+
signal,
202205
CallFrontListView(view),
203206
CallBackListView(model, view, master, value))
204207
misc.setdefault('uniformItemSizes', True)
@@ -500,8 +503,8 @@ def __call__(self, *_):
500503
from Orange.widgets.utils.itemmodels import PyListModel
501504

502505
selection = self.view.selectionModel().selection()
503-
if isinstance(self.view.model(), QSortFilterProxyModel):
504-
selection = self.view.model().mapSelectionToSource(selection)
506+
if isinstance(self.view, ListViewFilter):
507+
selection = self.view.selection
505508
values = [i.row() for i in selection.indexes()]
506509

507510
# set attribute's values

requirements-gui.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
orange-canvas-core>=0.2.2,<0.3a
2-
orange-widget-base>=4.23.0
2+
orange-widget-base>=4.25.0
33

44
AnyQt>=0.2.0
55

0 commit comments

Comments
 (0)