Skip to content

Commit c597742

Browse files
authored
Merge pull request #1654 from VesnaT/boxplot_attrs
[FIX] OWBoxPlot: Reset widget's appearance when data is removed
2 parents 0791308 + 9542456 commit c597742

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

Orange/widgets/visualize/owboxplot.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -231,6 +231,10 @@ def set_data(self, dataset):
231231
def reset_all_data(self):
232232
self.clear_scene()
233233
self.infot1.setText("")
234+
self.attrs[:] = []
235+
self.group_vars[:] = []
236+
self.is_continuous = False
237+
self.update_display_box()
234238

235239
def attr_changed(self):
236240
self.compute_box_data()

Orange/widgets/visualize/tests/test_owboxplot.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,13 +19,18 @@ def setUpClass(cls):
1919
def setUp(self):
2020
self.widget = self.create_widget(OWBoxPlot)
2121

22-
@skip("Known bug, FIXME!")
2322
def test_input_data(self):
2423
"""Check widget's data"""
2524
self.send_signal("Data", self.iris)
26-
self.assertGreater(len(self.widget.attrs), 0)
25+
self.assertEqual(len(self.widget.attrs), 5)
26+
self.assertEqual(len(self.widget.group_vars), 2)
27+
self.assertFalse(self.widget.display_box.isHidden())
28+
self.assertTrue(self.widget.stretching_box.isHidden())
2729
self.send_signal("Data", None)
2830
self.assertEqual(len(self.widget.attrs), 0)
31+
self.assertEqual(len(self.widget.group_vars), 0)
32+
self.assertTrue(self.widget.display_box.isHidden())
33+
self.assertFalse(self.widget.stretching_box.isHidden())
2934

3035
def test_input_data_missings_cont_group_var(self):
3136
"""Check widget with continuous data with missing values and group variable"""

0 commit comments

Comments
 (0)