Merge pull request #3508 from janezd/variable-selection-view

Easier selection of variables in Radviz, Linear projection and similar

Author: VesnaT

Orange/widgets/gui.py

@@ -1077,12 +1077,12 @@ def sizeHint(self):
 
 
 def listView(widget, master, value=None, model=None, box=None, callback=None,
-             sizeHint=None, **misc):
+             sizeHint=None, *, viewType=ListViewWithSizeHint, **misc):
     if box:
         bg = vBox(widget, box, addToLayout=False)
     else:
         bg = widget
-    view = ListViewWithSizeHint(preferred_size=sizeHint)
+    view = viewType(preferred_size=sizeHint)
     view.setModel(model)
     if value is not None:
         connectControl(master, value, callback,

Orange/widgets/settings.py

@@ -453,7 +453,7 @@ def write_defaults(self):
                 self.write_defaults_file(settings_file)
             except (EOFError, IOError, pickle.PicklingError) as ex:
                 log.error("Could not write default settings for %s (%s).",
-                          self.widget_class, type(ex).__name__)
+                          self.widget_class, ex)
                 settings_file.close()
                 os.remove(filename)
             else:

Orange/widgets/utils/listfilter.py

@@ -169,7 +169,8 @@ def eventFilter(self, obj, event):
             return False
 
 
-def variables_filter(model, parent=None, accepted_type=Orange.data.Variable):
+def variables_filter(model, parent=None, accepted_type=Orange.data.Variable,
+                     view_type=VariablesListItemView):
     """
     GUI components: ListView with a lineedit which works as a filter. One can write
     a variable name in a edit box and possible matches are then shown in a listview.
@@ -221,7 +222,7 @@ def update_completer_prefix():
 
     proxy = VariableFilterProxyModel()
     proxy.setSourceModel(model)
-    view = VariablesListItemView(acceptedType=accepted_type)
+    view = view_type(acceptedType=accepted_type)
     view.setModel(proxy)
 
     model.dataChanged.connect(update_completer_model)