Merge pull request #7192 from ales-erjavec/oweditdomain-reinterpret-numeric-as-time

[ENH ] Edit Domain: Reinterpret Numeric as Time with Unit

Author: ajdapretnar

Orange/data/tests/test_variable.py

@@ -756,6 +756,11 @@ def test_repr_value(self):
         var = TimeVariable('time')
         self.assertEqual(var.repr_val(Value(var, 416.3)), '416.3')
 
+    def test_repr_value_out_of_bounds(self):
+        var = TimeVariable("T", have_date=True, have_time=True)
+        self.assertEqual(var.repr_val(1e300), "?")
+        self.assertEqual(var.repr_val(-1e300), "?")
+
     def test_have_date_have_time_in_construct(self):
         """Test if have_time and have_date is correctly set"""
         var = TimeVariable('time', have_date=1)

Orange/data/variable.py

@@ -1123,9 +1123,15 @@ def repr_val(self, val):
         if val < 0:
             if microseconds:
                 seconds, microseconds = seconds - 1, int(1e6) + microseconds
-            date = datetime.fromtimestamp(0, tz=self.timezone) + timedelta(seconds=seconds)
+            try:
+                date = datetime.fromtimestamp(0, tz=self.timezone) + timedelta(seconds=seconds)
+            except (OverflowError, ValueError):
+                return "?"
         else:
-            date = datetime.fromtimestamp(seconds, tz=self.timezone)
+            try:
+                date = datetime.fromtimestamp(seconds, tz=self.timezone)
+            except (OverflowError, ValueError):
+                return "?"
         date = str(date.replace(microsecond=microseconds))
 
         if self.have_date and not self.have_time: