Skip to content

Commit cd45d48

Browse files
authored
Merge pull request #6729 from PrimozGodec/test-python312
[CI] Test with Python 3.12
2 parents 478513b + e03201c commit cd45d48

File tree

4 files changed

+15
-15
lines changed

4 files changed

+15
-15
lines changed

.github/workflows/test.yml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
- name: Setup Python
2020
uses: actions/setup-python@v5
2121
with:
22-
python-version: 3.9
22+
python-version: '3.10'
2323

2424
- name: Install Tox
2525
run: |
@@ -37,12 +37,12 @@ jobs:
3737
fail-fast: False
3838
matrix:
3939
os: [ubuntu-22.04]
40-
python-version: [3.9, '3.10', '3.11']
40+
python-version: [3.9, '3.10', '3.11', '3.12']
4141
tox_env: [orange-released]
4242
name: [Released]
4343
include:
4444
- os: ubuntu-22.04
45-
python-version: '3.11'
45+
python-version: '3.12'
4646
tox_env: orange-latest
4747
name: Latest
4848
- os: ubuntu-20.04
@@ -54,7 +54,7 @@ jobs:
5454
tox_env: pyqt6
5555
name: PyQt6
5656
- os: ubuntu-22.04
57-
python-version: '3.11'
57+
python-version: '3.12'
5858
tox_env: beta
5959
name: "Scientific Python nightly wheels"
6060

@@ -100,7 +100,7 @@ jobs:
100100
101101
- name: Skip testing workflows at coverage
102102
if: |
103-
matrix.python-version == '3.11' && matrix.tox_env == 'orange-released'
103+
matrix.python-version == '3.12' && matrix.tox_env == 'orange-released'
104104
run: |
105105
echo 'SKIP_EXAMPLE_WORKFLOWS=1' >> $GITHUB_ENV
106106
@@ -111,7 +111,7 @@ jobs:
111111
ORANGE_TEST_DB_URI: postgres://postgres_user:postgres_password@localhost:5432/postgres_db|mssql://SA:sqlServerPassw0rd@localhost:1433
112112

113113
- name: Upload code coverage
114-
if: matrix.python-version == '3.11' && matrix.tox_env == 'orange-released'
114+
if: matrix.python-version == '3.12' && matrix.tox_env == 'orange-released'
115115
uses: codecov/codecov-action@v4
116116
with:
117117
fail_ci_if_error: true
@@ -125,16 +125,16 @@ jobs:
125125
fail-fast: false
126126
matrix:
127127
os: [macos-latest, windows-latest]
128-
python-version: [3.9, '3.10', '3.11']
128+
python-version: [3.9, '3.10', '3.11', '3.12']
129129
tox_env: [orange-released]
130130
name: [Released]
131131
include:
132132
- os: windows-latest
133-
python-version: '3.11'
133+
python-version: '3.12'
134134
tox_env: orange-latest
135135
name: Latest
136136
- os: macos-latest
137-
python-version: '3.11'
137+
python-version: '3.12'
138138
tox_env: orange-latest
139139
name: Latest
140140
- os: windows-latest

Orange/tests/test_ada_boost.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@
22
# pylint: disable=missing-docstring
33

44
import unittest
5-
from distutils.version import LooseVersion
65

76
import numpy as np
7+
from packaging.version import Version
88

99
import Orange
1010
from Orange.data import Table
@@ -110,7 +110,7 @@ def test_adaboost_adequacy_reg(self):
110110
self.assertRaises(ValueError, learner, self.iris)
111111

112112
def test_remove_deprecation(self):
113-
if LooseVersion(Orange.__version__) >= LooseVersion("3.39"):
113+
if Version(Orange.__version__) >= Version("3.39"):
114114
self.fail(
115115
"`base_estimator` was deprecated in "
116116
"version 3.37. Please remove everything related to it."

Orange/tests/test_base.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
# pylint: disable=missing-docstring
33
import pickle
44
import unittest
5-
from distutils.version import LooseVersion
5+
6+
from packaging.version import Version
67

78
import Orange
89

@@ -137,7 +138,7 @@ def test_callback(self):
137138
def test_supports_weights_property(self):
138139
"""This test is to be included in the 3.37 release and will fail in
139140
version 3.39. This serves as a reminder."""
140-
if LooseVersion(Orange.__version__) >= LooseVersion("3.39"):
141+
if Version(Orange.__version__) >= Version("3.39"):
141142
self.fail(
142143
"`SklLearner.supports_weights` as a property that parses fit() "
143144
"was deprecated in 3.37. Replace it with `supports_weights = False`"

Orange/widgets/evaluate/tests/test_owpredictions.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -633,9 +633,8 @@ def test_unregister_prediction_model(self):
633633
self.send_signal(self.widget.Inputs.predictors, log_reg_iris)
634634
self.send_signal(self.widget.Inputs.data, self.iris)
635635
self.widget.selection_store.unregister = Mock()
636-
prev_model = self.widget.predictionsview.model()
637636
self.send_signal(self.widget.Inputs.predictors, log_reg_iris)
638-
self.widget.selection_store.unregister.called_with(prev_model)
637+
self.widget.selection_store.unregister.assert_called_once()
639638

640639
def test_multi_inputs(self):
641640
w = self.widget

0 commit comments

Comments
 (0)