Add tests

Author: AndrejaKovacic

Orange/preprocess/preprocess.py

@@ -605,7 +605,8 @@ def __call__(self, data):
                 sparsness = data.X.shape[0] - np.count_nonzero(data.X, axis=0)
         else: # filter by nans
             if sp.issparse(data.X):
-                sparsness = np.sum(np.isnan(data.X.data), axis=0)
+                data_csc = sp.csc_matrix(data.X)
+                sparsness = [np.sum(np.isnan(data.X[:, i].data)) for i in range(data_csc.shape[1])]
             else:
                 sparsness = np.sum(np.isnan(data.X), axis=0)
         att = [a for a, s in zip(data.domain.attributes, sparsness) if s <= tailored_threshold]

Orange/tests/test_preprocess.py

@@ -221,6 +221,8 @@ def test_nan_sparse(self):
         self.data.X[:, 0] = 7
         true_out = self.data[:, 0]
         true_out.X = true_out.X.reshape(-1, 1)
+        self.data.X = csr_matrix(self.data.X)
+        true_out.X = csr_matrix(true_out.X)
         out = RemoveSparse(False, False, 0.5)(self.data)
         np.testing.assert_array_equal(out, true_out)
 

Orange/widgets/data/tests/test_owpreprocess.py

@@ -290,12 +290,19 @@ def test_editor(self):
                                                "useFixedThreshold": False})
 
         p = widget.createinstance(widget.parameters())
+        widget.filterSettingsClicked()
+        self.assertTrue(widget.percSpin.isEnabled())
+        self.assertFalse(widget.fixedSpin.isEnabled())
         self.assertIsInstance(p, RemoveSparse)
         self.assertEqual(p.fixed_threshold, False)
         self.assertEqual(p.filter_0, True)
         self.assertEqual(p.threshold, 5)
 
-        widget.setParameters({"useFixedThreshold" : True})
+        widget.setParameters({"useFixedThreshold" : True,
+                              "fixedThresh" : 30,
+                              "filter0" : False})
         p = widget.createinstance(widget.parameters())
         self.assertIsInstance(p, RemoveSparse)
         self.assertEqual(p.fixed_threshold, True)
+        self.assertEqual(p.threshold, 30)
+        self.assertFalse(p.filter_0)