Skip to content

Commit d1c26fd

Browse files
committed
gui: Fix an type error in CallFrontListView
... when the displayed model is empty.
1 parent f4343dc commit d1c26fd

File tree

3 files changed

+10
-3
lines changed

3 files changed

+10
-3
lines changed

Orange/widgets/data/oweditdomain.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -394,7 +394,8 @@ def __init__(self):
394394

395395
self.domain_model = itemmodels.VariableListModel()
396396
self.domain_view = QListView(
397-
selectionMode=QListView.SingleSelection
397+
selectionMode=QListView.SingleSelection,
398+
uniformItemSizes=True
398399
)
399400
self.domain_view.setModel(self.domain_model)
400401
self.domain_view.selectionModel().selectionChanged.connect(

Orange/widgets/gui.py

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1090,6 +1090,7 @@ def listView(widget, master, value=None, model=None, box=None, callback=None,
10901090
CallFrontListView(view),
10911091
CallBackListView(model, view, master, value))
10921092
misc.setdefault('addSpace', True)
1093+
misc.setdefault('uniformItemSizes', True)
10931094
miscellanea(view, bg, widget, **misc)
10941095
return view
10951096

@@ -2500,6 +2501,7 @@ def action(self, values):
25002501

25012502
selection = QItemSelection()
25022503
for value in values:
2504+
index = None
25032505
if not isinstance(value, int):
25042506
if isinstance(value, Variable):
25052507
search_role = TableVariable
@@ -2508,9 +2510,12 @@ def action(self, values):
25082510
value = str(value)
25092511
for i in range(model.rowCount()):
25102512
if model.data(model.index(i), search_role) == value:
2511-
value = i
2513+
index = i
25122514
break
2513-
selection.select(model.index(value), model.index(value))
2515+
else:
2516+
index = value
2517+
if index is not None:
2518+
selection.select(model.index(index), model.index(index))
25142519
sel_model.select(selection, sel_model.ClearAndSelect)
25152520

25162521

Orange/widgets/utils/listfilter.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@ def __init__(self, parent=None, acceptedType=Orange.data.Variable):
5353
self.setDragDropMode(self.DragDrop)
5454
self.setDefaultDropAction(Qt.MoveAction)
5555
self.setDragDropOverwriteMode(False)
56+
self.setUniformItemSizes(True)
5657
self.viewport().setAcceptDrops(True)
5758

5859
#: type | Tuple[type]

0 commit comments

Comments
 (0)