Merge pull request #6454 from ales-erjavec/owsave-auto-save-disable-warning

[ENH] owsavebase: Display a warning when auto save is disabled

Author: janezd

Orange/canvas/run.py

@@ -14,6 +14,14 @@
 # Imported to make webwidget addons work
 from Orange.widgets.utils.webview import WebviewWidget  # pylint: disable=unused-import
 
+LOG_LEVELS = [
+    logging.CRITICAL + 10,
+    logging.CRITICAL,
+    logging.ERROR,
+    logging.WARN,
+    logging.INFO,
+    logging.DEBUG
+]
 
 def main(argv=None):
     app = QApplication(list(argv) if argv else [])
@@ -28,13 +36,13 @@ def main(argv=None):
         )
     )
     parser.add_argument("--log-level", "-l", metavar="LEVEL", type=int,
-                        default=logging.CRITICAL, dest="log_level")
+                        default=3, dest="log_level")
     parser.add_argument("--config", default="Orange.canvas.config.Config",
                         type=str)
     parser.add_argument("file")
     args = parser.parse_args(argv[1:])
 
-    log_level = args.log_level
+    log_level = LOG_LEVELS[args.log_level]
     filename = args.file
     logging.basicConfig(level=log_level)
 
@@ -71,6 +79,9 @@ def on_finished():
                 if msg.contents and msg.severity == msg.Error:
                     print(msg.contents, msg.message_id, file=sys.stderr)
                     severity = msg.Error
+                elif msg.contents and msg.severity == msg.Warning and \
+                        log_level <= logging.WARNING:
+                    print(msg.contents, file=sys.stderr)
         if severity == UserMessage.Error:
             app.exit(1)
         else:

Orange/widgets/utils/save/owsavebase.py

@@ -41,6 +41,14 @@ class OWSaveBase(widget.OWWidget, openclass=True):
     class Information(widget.OWWidget.Information):
         empty_input = widget.Msg("Empty input; nothing was saved.")
 
+    class Warning(widget.OWWidget.Warning):
+        auto_save_disabled = widget.Msg(
+            "Auto save disabled.\n"
+            "Due to security reasons auto save is only restored for paths "
+            "that are in the same directory as the workflow file or in a "
+            "subtree of that directory."
+        )
+
     class Error(widget.OWWidget.Error):
         no_file_name = widget.Msg("File name is not set.")
         unsupported_format = widget.Msg("File format is unsupported.\n{}")
@@ -59,7 +67,7 @@ class Error(widget.OWWidget.Error):
     # workflow).
     stored_path = Setting("")
     stored_name = Setting("", schema_only=True)  # File name, without path
-    auto_save = Setting(False)
+    auto_save = Setting(False, schema_only=True)
 
     filters = []
 
@@ -77,6 +85,7 @@ def __init__(self, start_row=0):
         """
         super().__init__()
         self.data = None
+        self.__show_auto_save_disabled = False
         self._absolute_path = self._abs_path_from_setting()
 
         # This cannot be done outside because `filters` is defined by subclass
@@ -88,7 +97,7 @@ def __init__(self, start_row=0):
         grid.addWidget(
             gui.checkBox(
                 None, self, "auto_save", "Autosave when receiving new data",
-                callback=self.update_messages),
+                callback=self._on_auto_save_toggled),
             start_row, 0, 1, 2)
         self.bt_save = gui.button(
             self.buttonsArea, self,
@@ -129,7 +138,7 @@ def _abs_path_from_setting(self):
         workflow_dir = self.workflowEnv().get("basedir")
         if os.path.isabs(self.stored_path):
             if os.path.exists(self.stored_path):
-                self.auto_save = False
+                self._disable_auto_save_and_warn()
                 return self.stored_path
         elif workflow_dir is not None:
             return os.path.normpath(
@@ -139,6 +148,15 @@ def _abs_path_from_setting(self):
         self.auto_save = False
         return self.stored_path
 
+    def _disable_auto_save_and_warn(self):
+        if self.auto_save:
+            self.__show_auto_save_disabled = True
+        self.auto_save = False
+
+    def _on_auto_save_toggled(self):
+        self.__show_auto_save_disabled = False
+        self.update_messages()
+
     @property
     def filename(self):
         if self.stored_name:
@@ -264,6 +282,7 @@ def update_messages(self):
         """
         self.Error.no_file_name(shown=not self.filename and self.auto_save)
         self.Information.empty_input(shown=self.filename and self.data is None)
+        self.Warning.auto_save_disabled(shown=self.__show_auto_save_disabled)
 
     def update_status(self):
         """

Orange/widgets/utils/save/tests/test_owsavebase.py

@@ -157,6 +157,7 @@ def test_open_moved_workflow(self):
             self.assertPathEqual(w.last_dir, "/home/u/orange/a/b")
             self.assertPathEqual(w.filename, "/home/u/orange/a/b/c.foo")
             self.assertTrue(w.auto_save)
+            self.assertFalse(w.Warning.auto_save_disabled.is_shown())
 
             w = self.create_widget(
                 self.OWSaveMockWriter,
@@ -166,6 +167,7 @@ def test_open_moved_workflow(self):
             self.assertPathEqual(w.last_dir, "/home/u/orange/a/b")
             self.assertPathEqual(w.filename, "/home/u/orange/a/b/c.foo")
             self.assertFalse(w.auto_save)
+            self.assertFalse(w.Warning.auto_save_disabled.is_shown())
 
             w = self.create_widget(
                 self.OWSaveMockWriter,
@@ -175,6 +177,7 @@ def test_open_moved_workflow(self):
             self.assertPathEqual(w.last_dir, "/home/u/orange/a/d")
             self.assertPathEqual(w.filename, "/home/u/orange/a/d/c.foo")
             self.assertTrue(w.auto_save)
+            self.assertFalse(w.Warning.auto_save_disabled.is_shown())
 
             w = self.create_widget(
                 self.OWSaveMockWriter,
@@ -184,6 +187,7 @@ def test_open_moved_workflow(self):
             self.assertPathEqual(w.last_dir, "/home/u/orange/")
             self.assertPathEqual(w.filename, "/home/u/orange/c.foo")
             self.assertFalse(w.auto_save)
+            self.assertFalse(w.Warning.auto_save_disabled.is_shown())
 
             w = self.create_widget(
                 self.OWSaveMockWriter,
@@ -193,6 +197,7 @@ def test_open_moved_workflow(self):
             self.assertPathEqual(w.last_dir, "/home/u/orange/")
             self.assertPathEqual(w.filename, "/home/u/orange/c.foo")
             self.assertTrue(w.auto_save)
+            self.assertFalse(w.Warning.auto_save_disabled.is_shown())
 
             w = self.create_widget(
                 self.OWSaveMockWriter,
@@ -202,6 +207,7 @@ def test_open_moved_workflow(self):
             self.assertPathEqual(w.last_dir, "/home/u/orange/")
             self.assertPathEqual(w.filename, "/home/u/orange/c.foo")
             self.assertTrue(w.auto_save)
+            self.assertFalse(w.Warning.auto_save_disabled.is_shown())
 
     def test_move_workflow(self):
         """Widget correctly stores relative paths"""