Tree adapters: Pylint

Author: janezd

Orange/widgets/visualize/tests/test_owpythagoreanforest.py

@@ -10,10 +10,7 @@
 from Orange.widgets.tests.base import WidgetTest
 from Orange.widgets.tests.utils import simulate
 from Orange.widgets.visualize.owpythagoreanforest import OWPythagoreanForest
-from Orange.widgets.visualize.pythagorastreeviewer import (
-    PythagorasTreeViewer,
-    SquareGraphicsItem
-)
+from Orange.widgets.visualize.pythagorastreeviewer import PythagorasTreeViewer
 
 
 class TestOWPythagoreanForest(WidgetTest):

Orange/widgets/visualize/utils/tree/skltreeadapter.py

@@ -151,8 +151,9 @@ def short_rule(self, node):
 
     def attribute(self, node):
         feature_idx = self.splitting_attribute(node)
-        if feature_idx != self.FEATURE_UNDEFINED:
-            return self.domain.attributes[self.splitting_attribute(node)]
+        if feature_idx == self.FEATURE_UNDEFINED:
+            return None
+        return self.domain.attributes[self.splitting_attribute(node)]
 
     def splitting_attribute(self, node):
         return self._tree.feature[node]

Orange/widgets/visualize/utils/tree/treeadapter.py

@@ -41,7 +41,6 @@ def weight(self, node):
             The weight of the node relative to its siblings.
 
         """
-        pass
 
     @abstractmethod
     def num_samples(self, node):
@@ -57,7 +56,6 @@ def num_samples(self, node):
         int
 
         """
-        pass
 
     @abstractmethod
     def parent(self, node):
@@ -72,7 +70,6 @@ def parent(self, node):
         object
 
         """
-        pass
 
     @abstractmethod
     def has_children(self, node):
@@ -87,7 +84,6 @@ def has_children(self, node):
         bool
 
         """
-        pass
 
     def is_leaf(self, node):
         """Check if the given node is a leaf node.
@@ -117,7 +113,6 @@ def children(self, node):
             A iterable object containing the labels of the child nodes.
 
         """
-        pass
 
     def reverse_children(self, node):
         """Reverse children of a given node.
@@ -126,12 +121,10 @@ def reverse_children(self, node):
         ----------
         node : object
         """
-        pass
 
     def shuffle_children(self):
         """Randomly shuffle node's children in the entire tree.
         """
-        pass
 
     @abstractmethod
     def get_distribution(self, node):
@@ -152,7 +145,6 @@ def get_distribution(self, node):
             the number of nodes that belong to a given class inside the node.
 
         """
-        pass
 
     @abstractmethod
     def get_impurity(self, node):
@@ -167,7 +159,6 @@ def get_impurity(self, node):
         object
 
         """
-        pass
 
     @abstractmethod
     def rules(self, node):
@@ -183,7 +174,6 @@ def rules(self, node):
             A list of Rule objects, can be of any type.
 
         """
-        pass
 
     @abstractmethod
     def short_rule(self, node):
@@ -201,7 +191,6 @@ def attribute(self, node):
         -------
 
         """
-        pass
 
     def is_root(self, node):
         """Check if a given node is the root node.
@@ -228,7 +217,6 @@ def leaves(self, node):
         -------
 
         """
-        pass
 
     @abstractmethod
     def get_instances_in_nodes(self, dataset, nodes):
@@ -246,7 +234,6 @@ def get_instances_in_nodes(self, dataset, nodes):
         -------
 
         """
-        pass
 
     @abstractmethod
     def get_indices(self, nodes):
@@ -262,7 +249,6 @@ def max_depth(self):
         int
 
         """
-        pass
 
     @property
     @abstractmethod
@@ -277,7 +263,6 @@ def num_nodes(self):
         int
 
         """
-        pass
 
     @property
     @abstractmethod
@@ -289,7 +274,6 @@ def root(self):
         object
 
         """
-        pass
 
 
 class TreeAdapter(BaseTreeAdapter):