Skip to content

Commit ebf8354

Browse files
authored
Merge pull request #2023 from pavlin-policar/tests-owadaboost
Tests OWAdaBoost: Add param tests for classification/regression data
2 parents 156f588 + fe4f0c0 commit ebf8354

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

Orange/widgets/model/tests/test_owadaboost.py

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -14,13 +14,12 @@ def setUp(self):
1414
OWAdaBoost, stored_settings={"auto_apply": False})
1515
self.init()
1616
self.parameters = [
17-
# TODO Due to the way params are tested on the learner and the fact
18-
# that learners only receive a subset of these parameters, this
19-
# method of testing these parameters is not viable
20-
# ParameterMapping('algorithm', self.widget.cls_algorithm_combo,
21-
# self.widget.algorithms),
22-
# ParameterMapping('loss', self.widget.reg_algorithm_combo,
23-
# self.widget.losses),
17+
ParameterMapping('algorithm', self.widget.cls_algorithm_combo,
18+
self.widget.algorithms,
19+
problem_type="classification"),
20+
ParameterMapping('loss', self.widget.reg_algorithm_combo,
21+
[x.lower() for x in self.widget.losses],
22+
problem_type="regression"),
2423
ParameterMapping('learning_rate', self.widget.learning_rate_spin),
2524
ParameterMapping('n_estimators', self.widget.n_estimators_spin),
2625
ParameterMapping.from_attribute(

0 commit comments

Comments
 (0)