Skip to content

Commit f01cc80

Browse files
authored
Merge pull request #6153 from markotoplak/remove-pyqt-install-magic
[FIX] Remove pyqt5 install magic
2 parents 790fc8a + 76cc5ac commit f01cc80

File tree

2 files changed

+10
-14
lines changed

2 files changed

+10
-14
lines changed

README.md

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,6 +49,8 @@ conda config --set channel_priority strict
4949
conda create python=3 --yes --name orange3
5050
conda activate orange3
5151

52+
# Install PyQt and PyQtWebEngine
53+
conda install pyqt
5254
# Install Orange
5355
conda install orange3
5456
```
@@ -63,7 +65,9 @@ conda install orange3-<addon name>
6365
### Installing with pip
6466

6567
We recommend using our [standalone installer](https://orange.biolab.si/download) or conda, but Orange is also installable with pip. You will need a C/C++ compiler (on Windows we suggest using Microsoft Visual Studio Build Tools).
66-
68+
Orange needs PyQt to run. Install either:
69+
- PyQt5 and PyQtWebEngine: `pip install -r requirements-pyqt.txt`
70+
- PyQt6 and PyQt6-WebEngine: `pip install PyQt6 PyQt6-WebEngine`
6771

6872
### Installing with winget (Windows only)
6973

@@ -137,6 +141,8 @@ conda activate orange3
137141

138142
git clone ssh://git@github.com/$MY_GITHUB_USERNAME/orange3
139143

144+
# Install PyQT and PyQtWebEngine. You can also use PyQt6
145+
pip install -r requirements-pyqt.txt
140146
pip install -e orange3
141147
```
142148

@@ -175,6 +181,9 @@ create a conda environment, clone your forks, and install them:
175181
conda create python=3 --yes --name orange3
176182
conda activate orange3
177183

184+
# Install PyQT and PyQtWebEngine. You can also use PyQt6
185+
pip install -r requirements-pyqt.txt
186+
178187
git clone ssh://git@github.com/$MY_GITHUB_USERNAME/orange-widget-base
179188
pip install -e orange-widget-base
180189

setup.py

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,6 @@
3434
except ImportError:
3535
have_cython = False
3636

37-
try:
38-
import PyQt5.QtCore # pylint: disable=unused-import
39-
have_pyqt5 = True
40-
except ImportError:
41-
have_pyqt5 = False
42-
43-
is_conda = os.path.exists(os.path.join(sys.prefix, 'conda-meta'))
44-
4537
NAME = 'Orange3'
4638

4739
VERSION = '3.34.0'
@@ -91,11 +83,6 @@
9183

9284
requirements = ['requirements-core.txt', 'requirements-gui.txt']
9385

94-
# pyqt5 is named pyqt5 on pypi and pyqt on conda
95-
# due to possible conflicts, skip the pyqt5 requirement in conda environments
96-
# that already have pyqt
97-
if not (is_conda and have_pyqt5):
98-
requirements.append('requirements-pyqt.txt')
9986

10087
INSTALL_REQUIRES = sorted(set(
10188
line.partition('#')[0].strip()

0 commit comments

Comments
 (0)