From 8a434d0fdd0674b61f761fb19e2fba58e407f99b Mon Sep 17 00:00:00 2001 From: nikicc Date: Wed, 4 Jan 2017 12:07:49 +0100 Subject: [PATCH] OWImageViewer: Fix selection indexing For data sets with missing images indexing was incorrect. Instead of using positions in the Data Table, positions from the ThumbnailView were used, resulting in mismatch betwen selected instances and instances on the output. --- Orange/widgets/data/owimageviewer.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Orange/widgets/data/owimageviewer.py b/Orange/widgets/data/owimageviewer.py index 57f58fa8e8e..e7a544dd9db 100644 --- a/Orange/widgets/data/owimageviewer.py +++ b/Orange/widgets/data/owimageviewer.py @@ -991,12 +991,12 @@ def setupScene(self): if self.data: attr = self.stringAttrs[self.imageAttr] titleAttr = self.allAttrs[self.titleAttr] - instances = [inst for inst in self.data - if numpy.isfinite(inst[attr])] assert self.thumbnailView.count() == 0 size = QSizeF(self.imageSize, self.imageSize) - for i, inst in enumerate(instances): + for i, inst in enumerate(self.data): + if not numpy.isfinite(inst[attr]): # skip missing + continue url = self.urlFromValue(inst[attr]) title = str(inst[titleAttr])