fix: only start global session once (#744)

Author: arendjr

src/biome.ts

@@ -185,6 +185,10 @@ export default class Biome {
 	 * Starts the Biome instance.
 	 */
 	public async start() {
+		if (this._session && this.state !== "error") {
+			return; // Avoid starting the same session multiple times.
+		}
+
 		this.listenForLockfilesChanges();
 		this.listenForConfigChanges();
 
@@ -213,12 +217,6 @@ export default class Biome {
 			this.singleFileFolder,
 		);
 
-		if (!this._session) {
-			this.state = "error";
-			this.logger.error("Unable to create the Biome session.");
-			return;
-		}
-
 		try {
 			await this._session?.start();
 			this.logger.info("✅ Biome is ready.");

src/extension.ts

@@ -110,7 +110,8 @@ export default class Extension {
 	 * Creates the extension from the context
 	 */
 	public static create(context: ExtensionContext): Extension {
-		return Extension.instance ?? new Extension(context);
+		Extension.instance ??= new Extension(context);
+		return Extension.instance;
 	}
 
 	/**
@@ -293,7 +294,10 @@ export default class Extension {
 	private async createGlobalInstance(): Promise<void> {
 		const createGlobalInstanceIfNotExists = async () => {
 			if (!this.biomes.get("global")) {
-				this.biomes.set("global", Biome.createGlobalInstance(this));
+				const biome = Biome.createGlobalInstance(this);
+				biome.start();
+
+				this.biomes.set("global", biome);
 			}
 		};
 
@@ -343,8 +347,7 @@ export default class Extension {
 		window.onDidChangeActiveTextEditor(
 			debounce(async (editor?: TextEditor) => {
 				await createGlobalInstanceIfNeeded(editor);
-				await this.biomes.get("global")?.start();
-			}, 0),
+			}, 10),
 		);
 	}
 

src/session.ts

@@ -72,14 +72,6 @@ export default class Session {
 		this.client = undefined;
 	}
 
-	/**
-	 * Restarts the LSP session.
-	 */
-	public async restart() {
-		await this.stop();
-		await this.start();
-	}
-
 	/**
 	 * Creates a new language client for the session.
 	 */