fix: feedback v2

Author: Netail

crates/biome_graphql_analyze/src/lint/nursery/use_input_name.rs

@@ -8,7 +8,7 @@ use biome_graphql_syntax::{
     GraphqlSyntaxToken,
 };
 use biome_rowan::{AstNode, TextRange};
-use biome_rule_options::use_input_name::UseInputNameOptions;
+use biome_rule_options::use_input_name::{CheckInputType, UseInputNameOptions};
 
 declare_lint_rule! {
     /// Require mutation argument to be always called "input"
@@ -37,15 +37,16 @@ declare_lint_rule! {
     ///
     /// ### `checkInputType`
     ///
-    /// When the option `checkInputType` is enabled, the input type requires to be called `<mutation name>Input`.
+    /// With the option `checkInputType` on, the input type name requires to be called `<mutation name>Input`.
+    /// This can either be "loose" (case-insensitive) or "strict" (case-sensitive).
     /// Using the name of the mutation in the input type name will make it easier to find the mutation that the input type belongs to.
     ///
-    /// Default `false`
+    /// Default `"off"`
     ///
     /// ```json,options
     /// {
     ///   "options": {
-    ///     "checkInputType": true
+    ///     "checkInputType": "loose"
     ///   }
     /// }
     /// ```
@@ -56,27 +57,45 @@ declare_lint_rule! {
     /// }
     /// ```
     ///
-    /// ### `caseSensitiveInputType`
+    /// ```graphql,use_options
+    /// type Mutation {
+    ///   SetMessage(input: setMessageInput): String
+    /// }
+    /// ```
     ///
-    /// Treat input type names as case-sensitive.
+    /// ```graphql,use_options
+    /// type Mutation {
+    ///   SetMessage(input: SetMessageInput): String
+    /// }
+    /// ```
     ///
-    /// Default `true`
     ///
     /// ```json,options
     /// {
     ///   "options": {
-    ///     "checkInputType": true,
-    ///     "caseSensitiveInputType": false
+    ///     "checkInputType": "strict"
     ///   }
     /// }
     /// ```
     ///
-    /// ```graphql,use_options
+    /// ```graphql,expect_diagnostic,use_options
+    /// type Mutation {
+    ///   SetMessage(input: InputMessage): String
+    /// }
+    /// ```
+    ///
+    /// ```graphql,expect_diagnostic,use_options
     /// type Mutation {
     ///   SetMessage(input: setMessageInput): String
     /// }
     /// ```
     ///
+    /// ```graphql,use_options
+    /// type Mutation {
+    ///   SetMessage(input: SetMessageInput): String
+    /// }
+    /// ```
+    ///
     pub UseInputName {
         version: "next",
         name: "useInputName",
@@ -131,10 +150,10 @@ impl Rule for UseInputName {
                 ));
             }
 
-            let check_input_type = ctx.options().check_input_type();
-            if check_input_type {
-                let is_case_sensitive_input_type = ctx.options().case_sensitive_input_type();
-
+            let check_input_type = ctx.options().check_input_type;
+            if let Some(check_input_type) = check_input_type
+                && check_input_type != CheckInputType::Off
+            {
                 let any_type = argument.ty().ok()?;
 
                 let ty = find_input_type(any_type)?;
@@ -144,8 +163,8 @@ impl Rule for UseInputName {
                 let def_value_token = def_name.value_token().ok()?;
 
                 let valid_str = format!("{}Input", def_value_token.text_trimmed());
-                if (is_case_sensitive_input_type && ty_string != valid_str)
-                    || (!is_case_sensitive_input_type
+                if (check_input_type == CheckInputType::Strict && ty_string != valid_str)
+                    || (check_input_type == CheckInputType::Loose
                         && !ty_string.eq_ignore_ascii_case(&valid_str))
                 {
                     return Some(UseInputNameState::InvalidTypeName(

…ase-sensitive-input-type/invalid.graphql …putName/case-insensitive/invalid.graphqlcrates/biome_graphql_analyze/tests/specs/nursery/useInputName/case-sensitive-input-type/invalid.graphql renamed to crates/biome_graphql_analyze/tests/specs/nursery/useInputName/case-insensitive/invalid.graphql crates/biome_graphql_analyze/tests/specs/nursery/useInputName/case-sensitive-input-type/invalid.graphql renamed to crates/biome_graphql_analyze/tests/specs/nursery/useInputName/case-insensitive/invalid.graphql

@@ -6,8 +6,7 @@
         "useInputName": {
           "level": "error",
           "options": {
-            "checkInputType": true,
-            "caseSensitiveInputType": true
+            "checkInputType": "loose"
           }
         }
       }

…ensitive-input-type/invalid.graphql.snap …me/case-insensitive/invalid.graphql.snapcrates/biome_graphql_analyze/tests/specs/nursery/useInputName/case-sensitive-input-type/invalid.graphql.snap renamed to crates/biome_graphql_analyze/tests/specs/nursery/useInputName/case-insensitive/invalid.graphql.snap crates/biome_graphql_analyze/tests/specs/nursery/useInputName/case-sensitive-input-type/invalid.graphql.snap renamed to crates/biome_graphql_analyze/tests/specs/nursery/useInputName/case-insensitive/invalid.graphql.snap

@@ -6,8 +6,7 @@
         "useInputName": {
           "level": "error",
           "options": {
-            "checkInputType": true,
-            "caseSensitiveInputType": true
+            "checkInputType": "loose"
           }
         }
       }

…me/check-input-type/invalid.options.json …me/case-insensitive/invalid.options.jsoncrates/biome_graphql_analyze/tests/specs/nursery/useInputName/check-input-type/invalid.options.json renamed to crates/biome_graphql_analyze/tests/specs/nursery/useInputName/case-insensitive/invalid.options.json crates/biome_graphql_analyze/tests/specs/nursery/useInputName/check-input-type/invalid.options.json renamed to crates/biome_graphql_analyze/tests/specs/nursery/useInputName/case-insensitive/invalid.options.json

@@ -6,8 +6,7 @@
         "useInputName": {
           "level": "error",
           "options": {
-            "checkInputType": true,
-            "caseSensitiveInputType": false
+            "checkInputType": "strict"
           }
         }
       }