feat(analyze/html/vue): add useVueVForKey

Author: dyc3

.changeset/add-v-for-key-rule.md

@@ -0,0 +1,17 @@
+---
+"@biomejs/biome": patch
+---
+
+Added the rule [`useVueVForKey`](https://biomejs.dev/linter/rules/use-vue-v-for-key/), which enforces that any element using `v-for` also specifies a `key`.
+
+**Invalid**
+
+```vue
+<li v-for="item in items">{{ item }}</li>
+```
+
+**Valid**
+
+```vue
+<li v-for="item in items" :key="item.id">{{ item }}</li>
+```

crates/biome_configuration/src/analyzer/linter/rules.rs

@@ -10,6 +10,7 @@ pub mod no_vue_v_if_with_v_for;
 pub mod use_vue_consistent_v_bind_style;
 pub mod use_vue_consistent_v_on_style;
 pub mod use_vue_hyphenated_attributes;
+pub mod use_vue_v_for_key;
 pub mod use_vue_valid_template_root;
 pub mod use_vue_valid_v_bind;
 pub mod use_vue_valid_v_cloak;
@@ -21,4 +22,4 @@ pub mod use_vue_valid_v_on;
 pub mod use_vue_valid_v_once;
 pub mod use_vue_valid_v_pre;
 pub mod use_vue_valid_v_text;
-declare_lint_group! { pub Nursery { name : "nursery" , rules : [self :: no_ambiguous_anchor_text :: NoAmbiguousAnchorText , self :: no_script_url :: NoScriptUrl , self :: no_sync_scripts :: NoSyncScripts , self :: no_vue_v_if_with_v_for :: NoVueVIfWithVFor , self :: use_vue_consistent_v_bind_style :: UseVueConsistentVBindStyle , self :: use_vue_consistent_v_on_style :: UseVueConsistentVOnStyle , self :: use_vue_hyphenated_attributes :: UseVueHyphenatedAttributes , self :: use_vue_valid_template_root :: UseVueValidTemplateRoot , self :: use_vue_valid_v_bind :: UseVueValidVBind , self :: use_vue_valid_v_cloak :: UseVueValidVCloak , self :: use_vue_valid_v_else :: UseVueValidVElse , self :: use_vue_valid_v_else_if :: UseVueValidVElseIf , self :: use_vue_valid_v_html :: UseVueValidVHtml , self :: use_vue_valid_v_if :: UseVueValidVIf , self :: use_vue_valid_v_on :: UseVueValidVOn , self :: use_vue_valid_v_once :: UseVueValidVOnce , self :: use_vue_valid_v_pre :: UseVueValidVPre , self :: use_vue_valid_v_text :: UseVueValidVText ,] } }
+declare_lint_group! { pub Nursery { name : "nursery" , rules : [self :: no_ambiguous_anchor_text :: NoAmbiguousAnchorText , self :: no_script_url :: NoScriptUrl , self :: no_sync_scripts :: NoSyncScripts , self :: no_vue_v_if_with_v_for :: NoVueVIfWithVFor , self :: use_vue_consistent_v_bind_style :: UseVueConsistentVBindStyle , self :: use_vue_consistent_v_on_style :: UseVueConsistentVOnStyle , self :: use_vue_hyphenated_attributes :: UseVueHyphenatedAttributes , self :: use_vue_v_for_key :: UseVueVForKey , self :: use_vue_valid_template_root :: UseVueValidTemplateRoot , self :: use_vue_valid_v_bind :: UseVueValidVBind , self :: use_vue_valid_v_cloak :: UseVueValidVCloak , self :: use_vue_valid_v_else :: UseVueValidVElse , self :: use_vue_valid_v_else_if :: UseVueValidVElseIf , self :: use_vue_valid_v_html :: UseVueValidVHtml , self :: use_vue_valid_v_if :: UseVueValidVIf , self :: use_vue_valid_v_on :: UseVueValidVOn , self :: use_vue_valid_v_once :: UseVueValidVOnce , self :: use_vue_valid_v_pre :: UseVueValidVPre , self :: use_vue_valid_v_text :: UseVueValidVText ,] } }

crates/biome_diagnostics_categories/src/categories.rs

@@ -0,0 +1,118 @@
+use biome_analyze::{
+    Ast, Rule, RuleDiagnostic, RuleDomain, RuleSource, context::RuleContext, declare_lint_rule,
+};
+use biome_console::markup;
+use biome_html_syntax::{AnyVueDirective, HtmlAttributeList, VueDirectiveArgument};
+use biome_rowan::{AstNode, AstNodeList, TextRange};
+use biome_rule_options::use_vue_v_for_key::UseVueVForKeyOptions;
+
+declare_lint_rule! {
+    /// Enforce that elements using `v-for` also specify a unique `key`.
+    ///
+    /// When rendering lists with `v-for`, Vue relies on a `key` to track elements efficiently.
+    /// The `key` can be provided via longhand `v-bind:key` or shorthand `:key`.
+    ///
+    /// ## Examples
+    ///
+    /// ### Invalid
+    ///
+    /// ```vue,expect_diagnostic
+    /// <li v-for="item in items">{{ item }}</li>
+    /// ```
+    ///
+    /// ### Valid
+    ///
+    /// ```vue
+    /// <li v-for="item in items" :key="item.id">{{ item }}</li>
+    /// ```
+    ///
+    /// ```vue
+    /// <li v-for="item in items" v-bind:key="item.id">{{ item }}</li>
+    /// ```
+    ///
+    pub UseVueVForKey {
+        version: "next",
+        name: "useVueVForKey",
+        language: "html",
+        recommended: true,
+        domains: &[RuleDomain::Vue],
+        sources: &[RuleSource::EslintVueJs("require-v-for-key").same()],
+    }
+}
+
+impl Rule for UseVueVForKey {
+    type Query = Ast<HtmlAttributeList>;
+    type State = TextRange;
+    type Signals = Option<Self::State>;
+    type Options = UseVueVForKeyOptions;
+
+    fn run(ctx: &RuleContext<Self>) -> Option<Self::State> {
+        let attrs = ctx.query();
+        let mut has_v_for = None;
+        let mut has_key = false;
+        for attr in attrs.iter() {
+            if let Some(dir_any) = attr.as_any_vue_directive() {
+                match dir_any {
+                    AnyVueDirective::VueDirective(dir) => {
+                        if dir.name_token().is_ok_and(|t| t.text_trimmed() == "v-for") {
+                            has_v_for = Some(dir.range());
+                        }
+                        if dir.name_token().is_ok_and(|t| t.text_trimmed() == "v-bind")
+                            && let Some(arg) = dir.arg()
+                            && is_v_bind_key_argument(&arg)
+                        {
+                            has_key = true;
+                        }
+                    }
+                    AnyVueDirective::VueVBindShorthandDirective(sh) => {
+                        if let Ok(arg) = sh.arg()
+                            && is_v_bind_key_argument(&arg)
+                        {
+                            has_key = true;
+                        }
+                    }
+                    _ => {}
+                }
+                if has_v_for.is_some() && has_key {
+                    // early exit if both found
+                    return None;
+                }
+            }
+        }
+        if let (Some(v_for_range), false) = (has_v_for, has_key) {
+            return Some(v_for_range);
+        }
+        None
+    }
+
+    fn diagnostic(_ctx: &RuleContext<Self>, state: &Self::State) -> Option<RuleDiagnostic> {
+        Some(
+            RuleDiagnostic::new(
+                rule_category!(),
+                state,
+                markup! {
+                    "This element is using "<Emphasis>"v-for"</Emphasis>", but the "<Emphasis>"key"</Emphasis>" is missing."
+                },
+            )
+            .note(markup! {
+                "Using a unique key with "<Emphasis>"v-for"</Emphasis>" helps Vue optimize rendering and track elements efficiently. Failing to provide a key can result in unexpected behavior during updates. For example, if you want to do transition animations, using a key is necessary so Vue knows which element to apply the animation to."
+            })
+            .note(markup! {
+                "Provide the key using "<Emphasis>":key=\"value\""</Emphasis>", and have the value be a unique value from the items you are iterating over. For example: `<li v-for=\"item in items\" :key=\"item.id\">{{ item }}</li>`"
+            }),
+        )
+    }
+}
+
+#[inline(always)]
+fn is_v_bind_key_argument(arg: &VueDirectiveArgument) -> bool {
+    let Ok(arg) = arg.arg() else {
+        return false;
+    };
+    let Some(static_arg) = arg.as_vue_static_argument() else {
+        return false;
+    };
+    static_arg
+        .name_token()
+        .is_ok_and(|name| name.text() == "key")
+}

crates/biome_html_analyze/src/lint/nursery.rs

@@ -0,0 +1,10 @@
+<!-- should generate diagnostics -->
+<ul>
+  <li v-for="item in items">{{ item }}</li>
+</ul>
+
+<div class="wrapper" v-for="(item, i) in items" data-id="foo"></div>
+
+<template v-for="item in items">
+  <li>{{ item }}</li>
+</template>

crates/biome_html_analyze/src/lint/nursery/use_vue_v_for_key.rs

@@ -0,0 +1,82 @@
+---
+source: crates/biome_html_analyze/tests/spec_tests.rs
+expression: invalid.vue
+---
+# Input
+```html
+<!-- should generate diagnostics -->
+<ul>
+  <li v-for="item in items">{{ item }}</li>
+</ul>
+
+<div class="wrapper" v-for="(item, i) in items" data-id="foo"></div>
+
+<template v-for="item in items">
+  <li>{{ item }}</li>
+</template>
+
+```
+
+# Diagnostics
+```
+invalid.vue:3:7 lint/nursery/useVueVForKey ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  i This element is using v-for, but the key is missing.
+  
+    1 │ <!-- should generate diagnostics -->
+    2 │ <ul>
+  > 3 │   <li v-for="item in items">{{ item }}</li>
+      │       ^^^^^^^^^^^^^^^^^^^^^
+    4 │ </ul>
+    5 │ 
+  
+  i Using a unique key with v-for helps Vue optimize rendering and track elements efficiently. Failing to provide a key can result in unexpected behavior during updates. For example, if you want to do transition animations, using a key is necessary so Vue knows which element to apply the animation to.
+  
+  i Provide the key using :key="value", and have the value be a unique value from the items you are iterating over. For example: `<li v-for="item in items" :key="item.id">{{ item }}</li>`
+  
+  i This rule belongs to the nursery group, which means it is not yet stable and may change in the future. Visit https://biomejs.dev/linter/#nursery for more information.
+  
+
+```
+
+```
+invalid.vue:6:22 lint/nursery/useVueVForKey ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  i This element is using v-for, but the key is missing.
+  
+    4 │ </ul>
+    5 │ 
+  > 6 │ <div class="wrapper" v-for="(item, i) in items" data-id="foo"></div>
+      │                      ^^^^^^^^^^^^^^^^^^^^^^^^^^
+    7 │ 
+    8 │ <template v-for="item in items">
+  
+  i Using a unique key with v-for helps Vue optimize rendering and track elements efficiently. Failing to provide a key can result in unexpected behavior during updates. For example, if you want to do transition animations, using a key is necessary so Vue knows which element to apply the animation to.
+  
+  i Provide the key using :key="value", and have the value be a unique value from the items you are iterating over. For example: `<li v-for="item in items" :key="item.id">{{ item }}</li>`
+  
+  i This rule belongs to the nursery group, which means it is not yet stable and may change in the future. Visit https://biomejs.dev/linter/#nursery for more information.
+  
+
+```
+
+```
+invalid.vue:8:11 lint/nursery/useVueVForKey ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
+
+  i This element is using v-for, but the key is missing.
+  
+     6 │ <div class="wrapper" v-for="(item, i) in items" data-id="foo"></div>
+     7 │ 
+   > 8 │ <template v-for="item in items">
+       │           ^^^^^^^^^^^^^^^^^^^^^
+     9 │   <li>{{ item }}</li>
+    10 │ </template>
+  
+  i Using a unique key with v-for helps Vue optimize rendering and track elements efficiently. Failing to provide a key can result in unexpected behavior during updates. For example, if you want to do transition animations, using a key is necessary so Vue knows which element to apply the animation to.
+  
+  i Provide the key using :key="value", and have the value be a unique value from the items you are iterating over. For example: `<li v-for="item in items" :key="item.id">{{ item }}</li>`
+  
+  i This rule belongs to the nursery group, which means it is not yet stable and may change in the future. Visit https://biomejs.dev/linter/#nursery for more information.
+  
+
+```

crates/biome_html_analyze/tests/specs/nursery/useVueVForKey/invalid.vue

@@ -0,0 +1,10 @@
+<!-- should not generate diagnostics -->
+<ul>
+  <li v-for="item in items" :key="item.id">{{ item }}</li>
+</ul>
+
+<ul>
+  <li v-for="item in items" v-bind:key="item.id">{{ item }}</li>
+</ul>
+
+<div v-for="(item, i) in items" :key="i"></div>

crates/biome_html_analyze/tests/specs/nursery/useVueVForKey/invalid.vue.snap

@@ -0,0 +1,18 @@
+---
+source: crates/biome_html_analyze/tests/spec_tests.rs
+expression: valid.vue
+---
+# Input
+```html
+<!-- should not generate diagnostics -->
+<ul>
+  <li v-for="item in items" :key="item.id">{{ item }}</li>
+</ul>
+
+<ul>
+  <li v-for="item in items" v-bind:key="item.id">{{ item }}</li>
+</ul>
+
+<div v-for="(item, i) in items" :key="i"></div>
+
+```

crates/biome_html_analyze/tests/specs/nursery/useVueVForKey/valid.vue

@@ -402,6 +402,7 @@ pub mod use_vue_consistent_v_on_style;
 pub mod use_vue_define_macros_order;
 pub mod use_vue_hyphenated_attributes;
 pub mod use_vue_multi_word_component_names;
+pub mod use_vue_v_for_key;
 pub mod use_vue_valid_template_root;
 pub mod use_vue_valid_v_bind;
 pub mod use_vue_valid_v_cloak;