fix(html-formatter): remove extra space before > when bracketSameLine… (#9535)

Author: leno23

.changeset/fix-html-bracket-same-line-spacing.md

@@ -0,0 +1,5 @@
+---
+"@biomejs/biome": patch
+---
+
+Fixed [#9524](https://github.com/biomejs/biome/issues/9524): remove extra space before `>` when `bracketSameLine` is true and the self-closing slash is absent in HTML formatter.

crates/biome_html_formatter/src/html/auxiliary/self_closing_element.rs

@@ -42,7 +42,14 @@ impl FormatNodeRule<HtmlSelfClosingElement> for FormatHtmlSelfClosingElement {
                 // in the same group as the attributes, unless the token is being borrowed.
                 // When these tokens are borrowed, they are managed by the sibling `HtmlElementList` formatter.
                 if bracket_same_line {
-                    write!(f, [hard_space()])?;
+                    let is_void = node.is_void_element().unwrap_or_default();
+                    let will_have_slash = self_close_void_elements.is_always()
+                        || (slash_token.is_some()
+                            && !(is_void && self_close_void_elements.is_never()));
+
+                    if will_have_slash {
+                        write!(f, [hard_space()])?;
+                    }
                 } else if attributes.len() >= 1 {
                     if self_close_void_elements.is_always() {
                         write!(f, [soft_line_break_or_space()])?;

crates/biome_html_formatter/tests/specs/html/bracket-same-line/options.json

@@ -0,0 +1,7 @@
+{
+  "html": {
+    "formatter": {
+      "bracketSameLine": true
+    }
+  }
+}

crates/biome_html_formatter/tests/specs/html/bracket-same-line/void_elements.html

@@ -0,0 +1,8 @@
+<img
+  src="test.png"
+  alt="test" />
+<br />
+<input
+  type="text"
+  name="test" />
+<hr>

crates/biome_html_formatter/tests/specs/html/bracket-same-line/void_elements.html.snap

@@ -0,0 +1,70 @@
+---
+source: crates/biome_formatter_test/src/snapshot_builder.rs
+assertion_line: 212
+info: bracket-same-line/void_elements.html
+---
+
+# Input
+
+```html
+<img
+  src="test.png"
+  alt="test" />
+<br />
+<input
+  type="text"
+  name="test" />
+<hr>
+
+```
+
+
+=============================
+
+# Outputs
+
+## Output 1
+
+-----
+Indent style: Tab
+Indent width: 2
+Line ending: LF
+Line width: 80
+Attribute Position: Auto
+Bracket same line: false
+Whitespace sensitivity: css
+Indent script and style: false
+Self close void elements: never
+Trailing newline: true
+-----
+
+```html
+<img src="test.png" alt="test">
+<br>
+<input type="text" name="test">
+<hr>
+
+```
+
+## Output 1
+
+-----
+Indent style: Tab
+Indent width: 2
+Line ending: LF
+Line width: 80
+Attribute Position: Auto
+Bracket same line: true
+Whitespace sensitivity: css
+Indent script and style: false
+Self close void elements: never
+Trailing newline: true
+-----
+
+```html
+<img src="test.png" alt="test">
+<br>
+<input type="text" name="test">
+<hr>
+
+```