Skip to content

Commit f4b7296

Browse files
authored
feat(migrate): more metadata for rules from html-eslint (#9106)
1 parent fc9850c commit f4b7296

File tree

8 files changed

+59
-5
lines changed

8 files changed

+59
-5
lines changed

.changeset/grumpy-tires-roll.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@biomejs/biome": patch
3+
---
4+
5+
Updated rule source metadata for rules from `html-eslint`.

crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rs

Lines changed: 40 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

crates/biome_cli/src/execute/migrate/unsupported_rules.rs

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -328,6 +328,15 @@ pub const UNSUPPORTED_RULES: &[UnsupportedRule] = &[
328328
UnsupportedRule(EslintVueJs("space-infix-ops"), FormatterCovers),
329329
UnsupportedRule(EslintVueJs("space-unary-ops"), FormatterCovers),
330330
UnsupportedRule(EslintVueJs("template-curly-spacing"), FormatterCovers),
331+
UnsupportedRule(HtmlEslint("attrs-newline"), FormatterCovers),
332+
UnsupportedRule(HtmlEslint("element-newline"), FormatterCovers),
333+
UnsupportedRule(HtmlEslint("indent"), FormatterOption("indentWidth")),
334+
UnsupportedRule(HtmlEslint("lowercase"), FormatterCovers),
335+
UnsupportedRule(HtmlEslint("no-extra-spacing-attrs"), FormatterCovers),
336+
UnsupportedRule(HtmlEslint("no-extra-spacing-text"), FormatterCovers),
337+
UnsupportedRule(HtmlEslint("no-multiple-empty-lines"), FormatterCovers),
338+
UnsupportedRule(HtmlEslint("no-trailing-spaces"), FormatterCovers),
339+
UnsupportedRule(HtmlEslint("quotes"), FormatterCovers),
331340
];
332341

333342
#[cfg(test)]

crates/biome_html_analyze/src/lint/a11y/no_access_key.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ declare_lint_rule! {
4242
version: "2.4.0",
4343
name: "noAccessKey",
4444
language: "html",
45-
sources: &[RuleSource::EslintJsxA11y("no-access-key").same()],
45+
sources: &[RuleSource::EslintJsxA11y("no-access-key").same(), RuleSource::HtmlEslint("no-accesskey-attrs").same()],
4646
recommended: true,
4747
severity: Severity::Error,
4848
fix_kind: FixKind::Unsafe,

crates/biome_html_analyze/src/lint/a11y/no_positive_tabindex.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ declare_lint_rule! {
4242
version: "2.4.0",
4343
name: "noPositiveTabindex",
4444
language: "html",
45-
sources: &[RuleSource::EslintJsxA11y("tabindex-no-positive").same()],
45+
sources: &[RuleSource::EslintJsxA11y("tabindex-no-positive").same(), RuleSource::HtmlEslint("no-positive-tabindex").same()],
4646
recommended: true,
4747
severity: Severity::Error,
4848
fix_kind: FixKind::Unsafe,

crates/biome_html_analyze/src/lint/a11y/use_alt_text.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ declare_lint_rule! {
8585
version: "2.4.0",
8686
name: "useAltText",
8787
language: "html",
88-
sources: &[RuleSource::EslintJsxA11y("alt-text").same()],
88+
sources: &[RuleSource::EslintJsxA11y("alt-text").same(), RuleSource::HtmlEslint("require-img-alt").same()],
8989
recommended: true,
9090
severity: Severity::Error,
9191
}

crates/biome_html_analyze/src/lint/a11y/use_button_type.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ declare_lint_rule! {
3131
version: "2.4.0",
3232
name: "useButtonType",
3333
language: "html",
34-
sources: &[RuleSource::EslintReact("button-has-type").same()],
34+
sources: &[RuleSource::EslintReact("button-has-type").same(), RuleSource::HtmlEslint("require-button-type").same()],
3535
recommended: true,
3636
severity: Severity::Error,
3737
}

crates/biome_html_analyze/src/lint/a11y/use_html_lang.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ declare_lint_rule! {
3838
version: "2.4.0",
3939
name: "useHtmlLang",
4040
language: "html",
41-
sources: &[RuleSource::EslintJsxA11y("html-has-lang").same()],
41+
sources: &[RuleSource::EslintJsxA11y("html-has-lang").same(), RuleSource::HtmlEslint("require-lang").same()],
4242
recommended: true,
4343
severity: Severity::Error,
4444
}

0 commit comments

Comments
 (0)