📎 Add `reactCompiler` option for `useExhaustiveDependencies`

[arendjr]

Description

useExhaustiveDependencies currently reports a diagnostic when using functions that are not wrapped with useCallback as dependency: “[myFunc] changes on every re-render and should not be used as a hook dependency”.

This diagnostic is not accurate for users of the React Compiler, since it automatically wraps such functions.

To resolve this, I agree with this comment that we should introduce an option for this.

Before starting work on this, I think we need to agree what to call the option and where to place it. I think having a single reactCompiler option makes sense, so that if we need other changes to accommodate the React Compiler users still only need to set one option. But that leaves the question whether it should be on the useExhaustiveDependencies rule, or if other React-related rules may also benefit from this, in which case we may prefer to move it up. Suggestions welcome!

[tusharsnx]

Would it be good enough to split useExhaustiveDependencies into two buckets, one with "[myFunc] changes on every re-render and should not be used as a hook dependency" warning, and another with whatever is left of useExhaustiveDependencies?

The first rule can be manually disabled for now. In the future, based on some heuristics we can disable it by-default when the react-compiler is detected.

[arendjr]

@tusharsnx I think that's quite a sensible suggestion!

Note I'm also addressing your suggestion in #5486, since it might be a good use case for a reactCompiler domain.

[vladimir-ivanov]

can work on this one if the discussion can happen now and we get resolution :-)? just need to know what to implement

[arendjr]

I just looked at the implementation, and I think splitting useExhaustiveDependencies might be quite a hassle. It would result in two rules that need to perform very similar analysis, so even if it can be cleanly refactored out, I don't think it would be efficient.

@vladimir-ivanov Feel free to also have a look for yourself, of course, but I'd say, let's stick with a simple option for now :) Assigning to you!

[vladimir-ivanov]

any suggestions on the name for this option please? @arendjr maybe hasReactCompiler or similar?
or I also wonder if it is a terrible idea to use some sort of settings: {reactCompiler: on/ off} in biome.json, which can affect other biome rules too

[jmparsons]

Is there something I can do to have biome work in my project right now? We are using react 18, so we need support for deps included ie:

const myFn = useCallback(() => {}, [])
useEffect(myFn, [myFn]) // <-- we need this as dep in react 18

We are using biome 2 beta, and this is a bit of a blocker for us, we'd have to just disable it outright, which is not ideal.

[vladimir-ivanov]

also to confirm even if react-compiler is in scope (react 18+ AND eslint rule react-hooks is the rc version which detects it, it still throws the same error:

and eslint config

that said, it seems to be a simple change to disable function check IF react compiler option is set to true