📎 Break `useExhaustiveDependencies` into two rules

[crutchcorn]

Description

I was migrating to the newest version of Biome and noticed that it seems to group in two seemingly unrelated rules into one:

• × This hook do not specify all of its dependencies.
• × This hook specifies more dependencies than necessary.

Inside of useExhaustiveDependencies

However, there's a problem with doing so this way.

While does not specify all of its deps is a rule that's ported over from React's common ESLint rules, specifies more deps than necessary isn't a rule, as it doesn't break the React Rules of Hooks. Moreover, specifying additional deps is how you're able to get some functionality to work as-expected at times.

Because of this, we should:

• specifies more deps than necessary should be broken into a new rule
• This new rule should be marked as optional, not required

[ematipico]

How would you call the new rule?

[crutchcorn]

What about useOnlyRequiredDependencies?

[arendjr]

noExcessiveDependencies? :)

[arendjr]

If we implement the suggestion from #2509 , do you think we can close this issue? If I understand correctly, the main reason for splitting is to be able to disable one type of check, while leaving others enabled. But if we can make exceptions per dependency, I think that use case is also covered.

[arendjr]

Closing in favor of #2509.

[flatplate]

I think this suggestion still makes sense even with the special ignore.

A way to disable "more dependencies than necessary" rule at least for useEffect and useLayoutEffect should be provided imo since that is what useEffect is used for.

I am migrating a large codebase right now and having to ignore thousands lines should be unnecessary.

[arendjr]

It’s a fair point, although if it is indeed specific to these hooks (and not others), maybe a more specific configuration option might make sense instead of splitting 🤔

[flatplate]

I agree that an option for this rule, or maybe in the hook options, would be enough.