Smart places grouping

Author: bionicl

Arc-app-export-converter/HelpMethods.cs

@@ -2,11 +2,14 @@
 
 public static class HelpMethods {
 
-	// Copied from
-	// https://stackoverflow.com/questions/6366408/calculating-distance-between-two-latitude-and-longitude-geocoordinates
-
+	// Distance measure
 	public static float DistanceTo(XmlTimeline.Coordinates wp1, XmlTimeline.Coordinates wp2, char unit = 'K') {
+		// Copied from
+		// https://stackoverflow.com/questions/6366408/calculating-distance-between-two-latitude-and-longitude-geocoordinates
+
+
 		double rlat1 = Math.PI * wp1.lat / 180;
+
 		double rlat2 = Math.PI * wp2.lat / 180;
 		double theta = wp1.lon - wp2.lon;
 		double rtheta = Math.PI * theta / 180;
@@ -30,11 +33,23 @@ public static float DistanceTo(XmlTimeline.Coordinates wp1, XmlTimeline.Coordina
 
 		return distF;
 	}
+	public static float DistanceTo(JsonMoves.Day.Segment.Place.Location jwp1, JsonMoves.Day.Segment.Place.Location jwp2, char unit = 'K') {
+		XmlTimeline.Coordinates wp1 = new XmlTimeline.Coordinates(jwp1.lat, jwp1.lon);
+		XmlTimeline.Coordinates wp2 = new XmlTimeline.Coordinates(jwp2.lat, jwp2.lon);
+		return DistanceTo(wp1, wp2, unit);
+	}
 
+	// Time conversations
 	public static DateTime ParseIso8601(string iso8601Time) {
 		return DateTime.Parse(iso8601Time, null, System.Globalization.DateTimeStyles.RoundtripKind);
 	}
+	public static string ConvertToIso1601(DateTime time) {
+		string output = time.ToString(Iso1601Format);
+		return output.Replace(":", "");
+	}
+	public static string Iso1601Format = "yyyyMMddTHHmmsszzz";
 
+	// GPX conversion
 	public static XmlTimeline.Coordinates GetLatLon(string line) {
 		string lat = "";
 		string lon = "";
@@ -63,12 +78,7 @@ public static string LeaveCenterFromString(string text, string removeLeft, strin
 		return temp;
 	}
 
-	public static string ConvertToIso1601(DateTime time) {
-		string output = time.ToString(Iso1601Format);
-		return output.Replace(":", "");
-	}
-	public static string Iso1601Format = "yyyyMMddTHHmmsszzz";
-
+	// To Json conversion
 	public static JsonMoves.ActivityGroup ReturnGroup(ActivityType type) {
 		switch (type) {
 			case ActivityType.walking:

Arc-app-export-converter/PlacesManager.cs

@@ -25,7 +25,12 @@ public Place(int id, string name, JsonMoves.Day.Segment.Place.Location location)
 	}
 
 	public void AddVisit(DateTime startTime, DateTime endTime) {
-		visits.Add(new PlaceVisit(startTime, endTime));
+		PlaceVisit tempVisit = new PlaceVisit(startTime, endTime);
+		foreach (var item in visits) {
+			if (item.startTime == startTime)
+				return;
+		}
+		visits.Add(tempVisit);
 	}
 }
 
@@ -42,6 +47,7 @@ public PlacesSave(List<Place> places, int currentId) {
 public class PlacesManager {
 	static bool loaded;
 	static string placesFileName = "places.json";
+	static float distanceTolerance = 0.07f;
 
 	static List<Place> places = new List<Place>();
 	static int currentId;
@@ -58,7 +64,7 @@ public static bool Loaded {
 
 	public static int ReturnPlaceId(JsonMoves.Day.Segment.Place place, DateTime startTime, DateTime endTime) {
 		foreach (var item in places) {
-			if (place.name == item.name) {
+			if (CheckIfSamePlace(item, place)) {
 				item.AddVisit(startTime, endTime);
 				return item.id;
 			}
@@ -68,6 +74,13 @@ public static int ReturnPlaceId(JsonMoves.Day.Segment.Place place, DateTime star
 		newPlace.AddVisit(startTime, endTime);
 		return newPlace.id;
 	}
+	static bool CheckIfSamePlace(Place place, JsonMoves.Day.Segment.Place jsonPlace) {
+		if (place.name == jsonPlace.name) {
+			if (HelpMethods.DistanceTo(place.location, jsonPlace.location) <= distanceTolerance)
+				return true;
+		}
+		return false;
+	}
 
 	// Loading files
 	static void LoadPlaces() {

Arc-app-export-converter/XmlReader.cs

@@ -42,6 +42,10 @@ public Coordinates(string lat, string lon) {
 			this.lat = Convert.ToDouble(lat);
 			this.lon = Convert.ToDouble(lon);
 		}
+		public Coordinates(double lat, double lon) {
+			this.lat = lat;
+			this.lon = lon;
+		}
 		public override string ToString() {
 			return string.Format("Lat: {0}   Lon: {1}  Ele: {2}", lat, lon, ele);
 		}

README.md

@@ -7,6 +7,7 @@ Convert GPX exported from [Arc App][1] to storyline Json format used by abandome
 Converter generates all information used by Moves developers:
 - Calculates burned calories based on movement speed and body weight
 - Creates summary of all movement types
+- Sometimes GPX file can contain two different places with the same name - if those are too far from each other, converter will split it into two different places
 
 ### Usage:
 1. Download [newest release][2]
@@ -20,7 +21,6 @@ Converter generates all information used by Moves developers:
 
 ### TODO:
 - Export many files/month file into a single json
-- Create place id’s with smart place grouping based on name and coordinates
 
 [1]:	https://itunes.apple.com/app/arc-app-location-activity-tracker/id1063151918?mt=8
 [2]:	https://github.com/bionicl/Arc-app-export-converter/releases/